Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u8 values for enums VMStatus and TrustLevel #13

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

dmitry-erin
Copy link
Contributor

@dmitry-erin dmitry-erin commented Sep 4, 2024

u8 values for enums VMStatus and TrustLevel

Description

Ensure each variant of enum VMStatus and TrustLevel has a specific discriminant value (for better compatibility).

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@dmitry-erin dmitry-erin marked this pull request as ready for review September 4, 2024 08:47
dmitry-erin added a commit to tiiuae/ghaf-ctrl-panel that referenced this pull request Sep 4, 2024
PR to givc(tiiuae/ghaf-givc#13)
is made to ensure proper work.

Signed-off-by: dmitry-erin <[email protected]>
has a specific discriminant value

Signed-off-by: dmitry-erin <[email protected]>
@mbssrc mbssrc merged commit 65e38b9 into tiiuae:main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants