Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging and minor code improvements #11

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Aug 29, 2024

Description

More flexible control on logging, also more excessive logging in debug mode.
Also contains minor code improvements

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Log controlled by GIVC_LOG variable, as well as givc.admin.debug = true option.
Debug logging turned on in tests

avnik added 3 commits August 29, 2024 18:49
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
@avnik avnik changed the title Avnik/code improvement Logging and minor code improvements Aug 29, 2024
@mbssrc mbssrc merged commit 4e5a6d9 into tiiuae:main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants