Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_iv_internal_api_adaptor): iv msg types #121

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

isamu-takagi
Copy link
Collaborator

@isamu-takagi isamu-takagi commented Jul 5, 2024

PR Type

  • Bug Fix

Related Links

#116

Description

  • Fix that the control mode types were swapped
  • Change type alias name to be more clear

Review Procedure

Launch planning simulation with option launch_deprecated_api:=true
Check iv_msg/control_mode types is autoware_auto_msgs.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link

@Owen-Liuyuxuan Owen-Liuyuxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked in the new internal version that the four topics are now coherent with other parts of Autoware.

@isamu-takagi isamu-takagi merged commit d800841 into tier4/universe Jul 8, 2024
14 checks passed
@isamu-takagi isamu-takagi deleted the fix/iv-msg-type branch July 8, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants