Skip to content

Commit

Permalink
Prepare for release
Browse files Browse the repository at this point in the history
  • Loading branch information
@hadley
hadley committed Feb 19, 2018
1 parent 28d6913 commit fe1de5c
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 45 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: forcats
Title: Tools for Working with Categorical Variables (Factors)
Version: 0.2.0.9000
Version: 0.3.0
Authors@R: c(
person("Hadley", "Wickham", , "[email protected]", role = c("aut", "cre")),
person("RStudio", role = c("cph", "fnd"))
Expand Down
38 changes: 23 additions & 15 deletions NEWS.md
View file
Original file line number Diff line number Diff line change
@@ -1,36 +1,44 @@
# forcats 0.2.0.9000
# forcats 0.3.0

* `fct_relabel()` now accepts objects coercible to functions
by `rlang::as_function` (#91, @alistaire47)
## API changes

* Increase test coverage from 80% to 99%.

* `fct_explicit_na()` also replaces NAs encoded in levels.

* [API] `fct_c()` now requires explicit splicing with `!!!` if you have a
* `fct_c()` now requires explicit splicing with `!!!` if you have a
list of factors that you want to combine. This is consistent with an emerging
standards for handling `...` throughout the tidyverse.

* [API] `fct_reorder()` and `fct_reorder2()` have renamed `fun` to `.fun` to
* `fct_reorder()` and `fct_reorder2()` have renamed `fun` to `.fun` to
avoid spurious matching of named arguments.

## New features

* All functions that take `...` use "tidy" dots: this means that you use can
`!!!` to splice in a list of values, and trailing empty arguments are
automatically removed. Additionally, all other arguments gain a `.` prefix
in order to avoid unhelpful matching of named arguments (#110).

* `fct_drop()` now preserves attributes (#83).
* `fct_lump()` gains `w` argument (#70, @wilkox) to weight value
frequencies before lumping them together (#68).

* `lvls_revalue()` preserves NA levels.
## Improvements to NA handling

* `as_factor()` and `fct_inorder()` accept NA levels (#98).

* `fct_explicit_na()` also replaces NAs encoded in levels.

* `fct_lump()` correctly acccounts for `NA` values in input (#41)

* `fct_expand()` and `lvls_expand()` now also take character vectors (#99).
* `lvls_revalue()` preserves NA levels.

* `as_factor()` and `fct_inorder()` accept NA levels (#98).
## Minor improvements and bug fixes

* `fct_lump()` gains `w` argument (#70, @wilkox) to weight value
frequencies before lumping them together (#68).
* Test coverage increased from 80% to 99%.

* `fct_drop()` now preserves attributes (#83).

* `fct_expand()` and `lvls_expand()` now also take character vectors (#99).

* `fct_relabel()` now accepts objects coercible to functions
by `rlang::as_function` (#91, @alistaire47)

# forcats 0.2.0

Expand Down
13 changes: 7 additions & 6 deletions cran-comments.md
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
## Test environments
* local OS X install, R 3.3.2
* ubuntu 12.04 (on travis-ci), R 3.3.2
* win-builder (devel and release)
* local: R-release (OS X)
* win-builder: R-devel
* travis: R 3.1, R 3.2, R-oldrel, R-release, R-devel

## R CMD check results

0 errors | 0 warnings | 0 notes

## Reverse dependencies
## revdepcheck results

I ran R CMD check on all 2 revdeps and did not find any problems.
We checked 24 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

Summary at https://github.com/tidyverse/forcats/tree/master/revdep
* We saw 0 new problems
* We failed to check 0 packages
7 changes: 4 additions & 3 deletions revdep/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
|version |R version 3.4.2 (2017-09-28) |
|os |macOS High Sierra 10.13.3 |
|system |x86_64, darwin15.6.0 |
|ui |X11 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|tz |America/Chicago |
|date |2018-02-12 |
|date |2018-02-19 |

# Dependencies

Expand All @@ -27,7 +27,7 @@

# Revdeps

## All (23)
## All (24)

|package |version |error |warning |note |
|:----------------------------------------------|:-------|:-----|:-------|:----|
Expand All @@ -51,6 +51,7 @@
|[railtrails](problems.md#railtrails) |0.0.3 | | |1 |
|[sjPlot](problems.md#sjplot) |2.4.1 | | |1 |
|[sweep](problems.md#sweep) |0.2.0 | | |1 |
|[tidyLPA](problems.md#tidylpa) |0.1.2 | | |1 |
|[tidyquant](problems.md#tidyquant) |0.5.3 |1 |2 |1 |
|[tidyverse](problems.md#tidyverse) |1.2.1 | |1 |1 |
|[timetk](problems.md#timetk) |0.1.0 | | |1 |
Expand Down
52 changes: 32 additions & 20 deletions revdep/problems.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ Version: 0.4.0
* checking installed package size ... NOTE
```
installed size is 5.3Mb
installed size is 5.1Mb
sub-directories of 1Mb or more:
data 5.0Mb
data 4.8Mb
```
* checking data for non-ASCII characters ... NOTE
Expand Down Expand Up @@ -139,6 +139,18 @@ Version: 0.2.0
All declared Imports should be used.
```
# tidyLPA
Version: 0.1.2
## In both
* checking dependencies in R code ... NOTE
```
Namespace in Imports field not imported from: ‘purrr’
All declared Imports should be used.
```
# tidyquant
Version: 0.5.3
Expand All @@ -155,7 +167,7 @@ Version: 0.5.3
10: typeof(x)
11: duplicate(quo)
══ testthat results ═══════════════════════════════════════════════════════════
══ testthat results ═══════════════════════════════════════════════════════════════════════════════════════
OK: 149 SKIPPED: 2 FAILED: 5
1. Failure: Test returns tibble with correct rows and columns. (@test_tq_get_key_stats.R#15)
2. Failure: Test returns tibble with correct rows and columns. (@test_tq_get_key_stats.R#17)
Expand All @@ -182,25 +194,25 @@ Version: 0.5.3
```
...
The following object is masked from 'package:dplyr':
as_tibble
The following object is masked from 'package:tibble':
as_tibble
Getting holdings for SP500
Getting data...
additional arguments ignored in warning()
Warning in fun_transmute(eval(parse(text = x)), OHLC = FALSE, ...) :
missing values removed from data
Warning: x = 'AAPL', get = 'key.ratios': Error in value[[3L]](cond): object 'key_ratios' not found
Warning in download.file(url, destfile = tmp, quiet = TRUE) :
URL 'http://download.finance.yahoo.com/d/quotes.csv?s=AAPL&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv': status was 'Couldn't resolve host name'
Warning: x = 'AAPL', get = 'key.stats': Error in download.file(url, destfile = tmp, quiet = TRUE): cannot open URL 'http://download.finance.yahoo.com/d/quotes.csv?s=AAPL&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv'
Quitting from lines 175-178 (TQ01-core-functions-in-tidyquant.Rmd)
Warning in download.file(url, destfile = tmp, quiet = TRUE) :
URL 'http://download.finance.yahoo.com/d/quotes.csv?s=AAPL&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv': status was 'Couldn't resolve host name'
Warning: x = 'AAPL', get = 'key.stats': Error in download.file(url, destfile = tmp, quiet = TRUE): cannot open URL 'http://download.finance.yahoo.com/d/quotes.csv?s=AAPL&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv'
Removing AAPL.
Warning in download.file(url, destfile = tmp, quiet = TRUE) :
URL 'http://download.finance.yahoo.com/d/quotes.csv?s=FB&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv': status was 'Couldn't resolve host name'
Warning: x = 'FB', get = 'key.stats': Error in download.file(url, destfile = tmp, quiet = TRUE): cannot open URL 'http://download.finance.yahoo.com/d/quotes.csv?s=FB&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv'
Removing FB.
Warning in download.file(url, destfile = tmp, quiet = TRUE) :
URL 'http://download.finance.yahoo.com/d/quotes.csv?s=GOOG&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv': status was 'Couldn't resolve host name'
Warning: x = 'GOOG', get = 'key.stats': Error in download.file(url, destfile = tmp, quiet = TRUE): cannot open URL 'http://download.finance.yahoo.com/d/quotes.csv?s=GOOG&f=aa2a5bb4b6c1c4dd1ee7e8e9f6ghjj1j2j4j5j6kk3k4k5ll1mm3m4m5m6m7m8nopp2p5p6qrr1r5r6r7s6s7t8vwxy&e=.csv'
Removing GOOG.
Quitting from lines 211-214 (TQ01-core-functions-in-tidyquant.Rmd)
Error: processing vignette 'TQ01-core-functions-in-tidyquant.Rmd' failed with diagnostics:
no applicable method for 'filter_' applied to an object of class "logical"
object 'Ask' not found
Execution halted
```
Expand Down

0 comments on commit fe1de5c

Please sign in to comment.