Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rails 8.0 #188

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Support for Rails 8.0 #188

merged 5 commits into from
Jan 15, 2025

Conversation

chtzvt
Copy link
Contributor

@chtzvt chtzvt commented Jan 14, 2025

This PR follows prior art to introduce support for Rails 8. It resolves #187.

Appreciate everyone's great work on this library :)

@thuss
Copy link
Owner

thuss commented Jan 15, 2025

Fantastic, assuming CI passes (currently running) we'll get this merged and publish a new version of the gem!

@thuss
Copy link
Owner

thuss commented Jan 15, 2025

Looks like some of the test configurations failed, once those are addressed we can get this merged.

@chtzvt
Copy link
Contributor Author

chtzvt commented Jan 15, 2025

@thuss I went ahead and added a conditional that selects the appropriate sqlite3 version:

  • AR 8.x requires sqlite3 >= 2.1 (ref)
  • Other AR versions fall back to the previous default of < 1.7.

Since the Rails team is increasingly focused on sqlite as a framework default, I figured this library will need to be more granular about sqlite versions going forward.

@thuss thuss merged commit 5496ce0 into thuss:master Jan 15, 2025
19 checks passed
@thuss
Copy link
Owner

thuss commented Jan 15, 2025

Thanks for your work on this! I've published a new version of the gem that includes this PR: https://rubygems.org/gems/standalone_migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Rails 8.0 to install
2 participants