common: Replace StringDataCompare with slices.Contains and cleanup string funcs #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
+ Coverage 36.50% 38.35% +1.84%
==========================================
Files 414 414
Lines 179351 149152 -30199
==========================================
- Hits 65472 57201 -8271
+ Misses 106004 84076 -21928
Partials 7875 7875
|
shazbert
requested changes
Aug 26, 2024
docs/ADD_NEW_EXCHANGE.md
Outdated
| @@ -267,9 +267,9 @@ func TestGetEnabledExchanges(t *testing.T) { | |||
| t.Errorf("received: '%v' but expected '%v'", len(exchanges), defaultEnabledExchanges) | |||
| } | |||
|
|
|||
| if !common.StringDataCompare(exchanges, "Bitfinex") { | |||
| if !slices.Contains(exchanges, "Bitfinex") { | |||
There was a problem hiding this comment.
suggestion: This is just pedantic nit picky all these changes on test files can use assert or require package. Resolve if you can't be bothered.
There was a problem hiding this comment.
I removed these since they aren't relevant anymore, can do a full updated pass in #1494 once Bitget PR is opened
| allowedGranularities := [6]int64{60, 300, 900, 3600, 21600, 86400} | ||
| validGran, _ := common.InArray(granularity, allowedGranularities) | ||
| if !validGran { | ||
| allowedGranularities := []int64{60, 300, 900, 3600, 21600, 86400} |
There was a problem hiding this comment.
NOTE: Just had a quick play and which I thought was interesting, we can reduce the two parameter instance of a lot of these. Out of scope though.
// Container is a generic type for slices
type Container[T comparable] []T
func (c Container[T]) Contains(in T) bool {
return slices.Contains(c, in)
}
func TestXxx(t *testing.T) {
allowedGranularities := Container[int64]{60, 300, 900, 3600, 21600, 86400}
assert.True(t, allowedGranularities.Contains(300))
}
thrasher-
force-pushed
the
common_strings
branch
from
80226e4 to
66f4770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Replace StringDataCompare with slices.Contains + a bit of a cleanup. I've made StringSliceDifference generic since I thought it might be useful moving forward, though since we don't currently use it anywhere now I'd be happy to rm -rf it 😈
Type of change
How has this been tested
Checklist