stream/match: allow a single connection to maintain its own match lookup for multi-connection #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 14, 2024 16:13
…larity on purpose. Change connections map to point to candidate to track subscriptions for future dynamic connections holder and drop struct ConnectionDetails.
…rror but websocket frame error or anything really makes the reader routine return and then connection never cycles and the buffer gets filled. * Handle reconnection via an errors.Is check which is simpler and in that scope allow for quick disconnect reconnect without waiting for connection cycle. * Dial now uses code from DialContext but just calls context.Background() * Don't allow reader to return on parse binary response error. Just output error and return a non nil response
…would hang connection reader for eternity.
added 12 commits
September 25, 2024 12:14
…ove code that is not needed.
…le to echo back ws data as it can be easily reviewed _test file side.
…ad of waiting for a time period, add sleep inline with echo handler as this is really quick and wanted to ensure that latency is handing correctly
added 8 commits
September 30, 2024 12:54
shazbert
added
review me
gloriousCode
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Thank you for adding this. I would just like to see a test from gateio_test.go along similar lines to this: #1601 (comment)
which would allow for your changes to be hit
If you want that I will just wait until #1598 is merged it has all the auth and outbound inbound testing done there. |
shazbert
added
nomerge requires dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Attempts to decouple a connection from a global lookup table for outbound request to response matching. This allows for generic startup messages to be used across future multiple connections of the same type. This also minimises the chance of a signature conflict on outbound requests. Potentially reduces the semacquire slowness when dealing with many concurrently spawned and subscribed return responses.
This is backwards compatible.
Starts implementation in Gateio due to websocket/gateio: Support multi connection management and integrate with GateIO #1580 base.
Requires #1580 #1581 #1598 (tests)
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist