Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yecc backend to parse unicode strings #2

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ejschmitt
Copy link
Contributor

I wanted to parse unicode string values with the Yecc backend, so added this change.

I'm not super familiar with the differences between :erlang.iolist_to_binary() vs :unicode.characters_to_binary(), so maybe it's not this easy?
Not sure, but hey, the tests pass 🤷

@thomas9911
Copy link
Owner

I think indeed I used :erlang.iolist_to_binary() to convert from a list to a binary. If the other function does that as well + supports unicode. That sounds good to me 👌

@thomas9911
Copy link
Owner

I fixed the github pipelines can you merge main into your branch?

@ejschmitt
Copy link
Contributor Author

Updated with master. The test updates for otp 26+ look good, I didn't want to change a bunch of stuff since I don't know the repo well. Thanks!

@thomas9911 thomas9911 merged commit 0803cee into thomas9911:main Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants