Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform base_field_type handling #1706

Merged
merged 1 commit into from
Dec 21, 2024

Uniform base_field_type handling

88eed80
Select commit
Loading
Failed to load commit list.
Merged

Uniform base_field_type handling #1706

Uniform base_field_type handling
88eed80
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 0s

75.99% (-0.05%) compared to 9f4ccb9

View this Pull Request on Codecov

75.99% (-0.05%) compared to 9f4ccb9

Details

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (9f4ccb9) to head (88eed80).

Files with missing lines Patch % Lines
src/Hecke.jl 0.00% 2 Missing ⚠️
src/Map/NumField.jl 0.00% 2 Missing ⚠️
src/Misc/RelFiniteField.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
- Coverage   76.03%   75.99%   -0.05%     
==========================================
  Files         361      361              
  Lines      114336   114334       -2     
==========================================
- Hits        86938    86884      -54     
- Misses      27398    27450      +52     
Files with missing lines Coverage Δ
src/LocalField/LocalField.jl 76.53% <ø> (+0.46%) ⬆️
src/Misc/RelFiniteField.jl 73.47% <0.00%> (-0.17%) ⬇️
src/Hecke.jl 50.77% <0.00%> (-0.32%) ⬇️
src/Map/NumField.jl 88.24% <0.00%> (+0.40%) ⬆️

... and 26 files with indirect coverage changes