Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use polynomial rings over zero rings #1684

Merged
merged 4 commits into from
Nov 18, 2024

more

4eb68b8
Select commit
Loading
Failed to load commit list.
Merged

fix: don't use polynomial rings over zero rings #1684

more
4eb68b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2024 in 0s

76.00% (-0.01%) compared to 0d6625a

View this Pull Request on Codecov

76.00% (-0.01%) compared to 0d6625a

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.00%. Comparing base (0d6625a) to head (4eb68b8).

Files with missing lines Patch % Lines
src/FunField/HessQR.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
- Coverage   76.01%   76.00%   -0.01%     
==========================================
  Files         362      362              
  Lines      114299   114306       +7     
==========================================
- Hits        86882    86880       -2     
- Misses      27417    27426       +9     
Files with missing lines Coverage Δ
src/Misc/nmod_poly.jl 62.30% <100.00%> (-1.27%) ⬇️
src/NumFieldOrd/NfOrd/Ideal/Ideal.jl 82.85% <100.00%> (+0.04%) ⬆️
src/FunField/HessQR.jl 69.67% <0.00%> (-0.29%) ⬇️

... and 28 files with indirect coverage changes