Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafe operations for FinGenAbGroupElem #1619

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

fingolfin
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.87%. Comparing base (a33221a) to head (40ef6c0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
- Coverage   75.94%   75.87%   -0.07%     
==========================================
  Files         361      361              
  Lines      113674   113697      +23     
==========================================
- Hits        86333    86273      -60     
- Misses      27341    27424      +83     
Files with missing lines Coverage Δ
src/GrpAb/Elem.jl 96.75% <100.00%> (+0.48%) ⬆️

... and 31 files with indirect coverage changes

src/GrpAb/Elem.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment, lgtm!

@fingolfin fingolfin force-pushed the mh/in-place-FinGenAbGroupElem branch from cb2962e to 40ef6c0 Compare September 20, 2024 19:34
@thofma thofma enabled auto-merge (squash) September 20, 2024 20:27
@thofma thofma merged commit 38aab56 into thofma:master Sep 20, 2024
17 checks passed
@fingolfin fingolfin deleted the mh/in-place-FinGenAbGroupElem branch September 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants