Some fixes (#1722)

thofma · Jan 16, 2025 · 577504b · 577504b
1 parent d45ee3f
commit 577504b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/LocalField/LocalField.jl b/src/LocalField/LocalField.jl
@@ -47,8 +47,8 @@ elem_type(::Type{LocalField{S, T}}) where {S <: FieldElem, T <: LocalFieldParame
 #
 ################################################################################
 
-is_domain_type(::Type{S}) where S <: LocalField = true
-is_exact_type(::Type{S}) where S <: LocalField = false
+is_domain_type(::Type{<: LocalFieldElem}) = true
+is_exact_type(::Type{<: LocalFieldElem}) = false
 isfinite(K::LocalField) = isfinite(base_field(K))
 
 ################################################################################

diff --git a/src/Misc/RelFiniteField.jl b/src/Misc/RelFiniteField.jl
@@ -141,6 +141,8 @@ iszero(x::RelFinFieldElem) = iszero(x.data)
 isone(x::RelFinFieldElem) = isone(x.data)
 is_unit(x::RelFinFieldElem) = !iszero(x)
 
+hash(x::RelFinFieldElem, h::UInt) = hash(x.data, h)
+
 ==(x::RelFinFieldElem{S, T}, y::RelFinFieldElem{S, T}) where {S, T} = x.data == y.data
 
 coeff(a::RelFinFieldElem, i::Int) = coeff(a.data, i)

diff --git a/src/NumField/Embedded.jl b/src/NumField/Embedded.jl
@@ -65,6 +65,8 @@ base_ring_type(::Type{<:EmbeddedNumField}) = QQField
 
 data(x::EmbeddedNumFieldElem) = x.element
 
+characteristic(::EmbeddedNumField) = 0
+
 function embedded_field(K::SimpleNumField, i::NumFieldEmb)
   @assert number_field(i) === K
   E = EmbeddedNumField(K, i)