Skip to content

Commit

Permalink
feat: residue fields of orders in global function fields
Browse files Browse the repository at this point in the history
  • Loading branch information
fieker authored and thofma committed Sep 17, 2024
1 parent 58f5733 commit 472f817
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/GenOrd/GenOrd.jl
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ basis_matrix_inverse(O::GenOrd{S}) where {S} = O.itrans::dense_matrix_type(elem_
#
################################################################################

function basis(O::GenOrd)
function basis(O::GenOrd; copy::Bool = true)
get_attribute!(O, :basis) do
if _is_standard(O)
return map(O, basis(field(O)))
Expand Down
3 changes: 3 additions & 0 deletions src/GenOrd/Types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ end
gen_two::GenOrdElem

princ_gen::GenOrdElem
prim_elem::GenOrdElem
min_poly_prim_elem
basis_in_prim

splitting_type::Tuple{Int, Int}
#ordered as ramification index, inertia degree
Expand Down
2 changes: 1 addition & 1 deletion src/NumFieldOrd/NfOrd/ResidueField.jl
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ end
# Compute the residue field data given the prime P
function compute_residue_field_data!(P)
p = minimum(P)
if fits(Int, p)
if isa(p, IntegerUnion) && fits(Int, p)
smallp = Int(p)
A, m = StructureConstantAlgebra(order(P), P, smallp)
compute_residue_field_data!(P, m)
Expand Down

0 comments on commit 472f817

Please sign in to comment.