Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psych sheet current user highlight/info/scroll #10625

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kr-matthews
Copy link
Contributor

The built-in active prop for a table row is barely noticeable (in the docs it's noticeable, so I'm not sure if we have some conflicting custom css or something?), so I did a custom background colour.

User competing in some but not all events:

Screencast.from.2025-01-14.04.09.16.PM.webm

User competing in events without an official result already:

Screencast.from.2025-01-14.04.10.25.PM.webm

Not logged in:

Screencast.from.2025-01-14.04.14.33.PM.webm

@kr-matthews kr-matthews self-assigned this Jan 15, 2025
@gregorbg
Copy link
Member

I've just pushed a CSS rule that will override Bootstrap, so if you use SemUI's active it should work as expected now.

@kr-matthews
Copy link
Contributor Author

I've just pushed a CSS rule that will override Bootstrap, so if you use SemUI's active it should work as expected now.

Thanks. It works. Any chance there's a similar issue making the table stripes less noticeable?

@coder13
Copy link
Contributor

coder13 commented Jan 18, 2025

My feelings are mixed on taking up the vertical space just for this functionality.

I don't have any different suggestions on this functionality.

I also feel we should not present the ranking information "Your rank is 19." as a sentence and rather it should be a more simplified view of "Rank: 19 / Average: xx.yy / Single: xx.yy" or similar.

@kr-matthews
Copy link
Contributor Author

My feelings are mixed on taking up the vertical space just for this functionality.

I don't have any different suggestions on this functionality.

I also feel we should not present the ranking information "Your rank is 19." as a sentence and rather it should be a more simplified view of "Rank: 19 / Average: xx.yy / Single: xx.yy" or similar.

One of the other tasks is to move the "10 first-timers + 75 returners = 85 people" out of the first column's footer, because you can't see it without scrolling to the bottom and it makes the first column unnecessarily wide. So I was thinking that that information could also move up to this box, in which case the vertical space is 'less wasteful' since it's showing more information.

I don't mind truncating the sentences like that, or keeping them, but it would be good to get feedback from anyone else on this.

An alternative would be to just have a floating button and no text/information above the table. Or moving the current user's row to the top of the table, but this would be awkward since the table is sortable and half the point is to see how you compare to those around you, so I'm not in favour of this.

@gregorbg
Copy link
Member

I don't mind truncating the sentences like that, or keeping them, but it would be good to get feedback from anyone else on this.

Speaking from my personal perspective (ie this is not a binding Team Leader instruction): I always like to have "statistical" information like the one you're mentioning be as condensed as possible. It reduces the workload on translators for information that easily translates across cultures without the need for fully phrased sentences.

And also yes, it saves space which will delight all those who want to squeeze as much information on their phone screen as humanly possible. And judging by some other recent React page launches, there are plenty of these people out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants