Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Competition Overview Page to React #10418

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

FinnIckler
Copy link
Member

Currently wip porting the registration requirements over

There is an issue that it only does one markdown request at once, but a bunch of fields are in markdown... so not sure what to do about that.

Progress:
image

@FinnIckler
Copy link
Member Author

Migrated all information over. Now onto the styling
Screenshot 2024-12-12 at 15 47 54
Screenshot 2024-12-12 at 15 48 03

@FinnIckler
Copy link
Member Author

Moving it to the grid with the right sizes was quite easy actually. But I don't really know what the correct equivalent of a Descriptive List is in Semantic

@FinnIckler
Copy link
Member Author

I can rebuild it with another grid, maybe that looks good enough

@FinnIckler
Copy link
Member Author

Screenshot 2024-12-12 at 21 42 04 I was able to replicate it with a grid, but I did have to set the padding to 0 manually

@FinnIckler
Copy link
Member Author

Screenshot 2024-12-13 at 00 11 24 Screenshot 2024-12-13 at 00 11 08 Almost everything moved over to grid

@FinnIckler
Copy link
Member Author

image
Mobile view

Copy link
Contributor

@kr-matthews kr-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Only viewed some of the files. Will do the rest later, if the PR is still open.)

@gregorbg
Copy link
Member

gregorbg commented Jan 5, 2025

Opinions?
image

Copy link
Contributor

@kr-matthews kr-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't fully reviewed everything yet.

I'd be in favour of having the main, exported function at the top of files.

@FinnIckler
Copy link
Member Author

I haven't fully reviewed everything yet.

I'd be in favour of having the main, exported function at the top of files.

Will that not cause a 'referenced before defined' eslint error?

@FinnIckler
Copy link
Member Author

Moved the numbers on the right to a Statisticgroup
image

Also added a 'Registrations' statistic that is shown instead of the competitor count when the competition isn't finished yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants