-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Competition Overview Page to React #10418
base: main
Are you sure you want to change the base?
Conversation
Moving it to the grid with the right sizes was quite easy actually. But I don't really know what the correct equivalent of a Descriptive List is in Semantic |
I can rebuild it with another grid, maybe that looks good enough |
226ea43
to
3c2f74e
Compare
app/webpacker/components/CompetitionTabs/Requirements/CompetitionSeriesRequirement.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/CompetitionSeriesRequirement.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/GuestRequirements.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/GuestRequirements.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/RegistrationFeeRequirements.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Only viewed some of the files. Will do the rest later, if the PR is still open.)
app/webpacker/components/CompetitionTabs/Requirements/GuestRequirements.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't fully reviewed everything yet.
I'd be in favour of having the main, exported function at the top of files.
app/webpacker/components/CompetitionTabs/GeneralInfo/DateAddressContact.jsx
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/GeneralInfo/DateAddressContact.jsx
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/GeneralInfo/DateAddressContact.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/GeneralInfo/InformationEvents.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/GeneralInfo/InformationEvents.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/RegistrationRequirements.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/RegistrationRequirements.jsx
Show resolved
Hide resolved
app/webpacker/components/CompetitionTabs/Requirements/RegistrationRequirements.jsx
Show resolved
Hide resolved
Will that not cause a 'referenced before defined' eslint error? |
Currently wip porting the registration requirements over
There is an issue that it only does one markdown request at once, but a bunch of fields are in markdown... so not sure what to do about that.
Progress: