-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace .at() interpolation in 2D callbacks #373
Conversation
- .at() raises an error when the number of processors used is large, use a VertexOnlyMesh instead for interpolation
Prevents the Firedrake issue #2790 whilst Firedrake issue #3080 is waiting to be resolved. This method is slower than There are some remaining direct applications of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Only minor comments
The current version of Firedrake is failing, which seems to be causing all the Thetis tests to fail. Waiting for this to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
.at() raises an error when the number of processors used is large, use a VertexOnlyMesh instead for interpolation