Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .at() interpolation in 2D callbacks #373

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

cpjordan
Copy link
Contributor

.at() raises an error when the number of processors used is large, use a VertexOnlyMesh instead for interpolation

- .at() raises an error when the number of processors used is large, use a VertexOnlyMesh instead for interpolation
@cpjordan
Copy link
Contributor Author

Prevents the Firedrake issue #2790 whilst Firedrake issue #3080 is waiting to be resolved. This method is slower than .at() so an alternative is to add a try except with .at() before moving onto using a VertexOnlyMesh.

There are some remaining direct applications of .at() but they are for 3D examples where either the callbacks are only being used in serial or where the problem is so large that .at() is functioning fine.

@cpjordan cpjordan marked this pull request as ready for review July 31, 2024 08:38
@thangel thangel requested review from tkarna and swarder October 9, 2024 14:52
Copy link
Contributor

@tkarna tkarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Only minor comments

thetis/callback.py Outdated Show resolved Hide resolved
thetis/callback.py Outdated Show resolved Hide resolved
thetis/callback.py Outdated Show resolved Hide resolved
thetis/callback.py Outdated Show resolved Hide resolved
thetis/callback.py Outdated Show resolved Hide resolved
thetis/callback.py Outdated Show resolved Hide resolved
thetis/callback.py Show resolved Hide resolved
@cpjordan
Copy link
Contributor Author

The current version of Firedrake is failing, which seems to be causing all the Thetis tests to fail. Waiting for this to be updated.

Copy link
Contributor

@tkarna tkarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpjordan cpjordan merged commit cf66f38 into master Dec 4, 2024
1 check passed
@cpjordan cpjordan deleted the replace-2d-callback-interpolations branch December 5, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants