Reduce Firedrake deprectation warnings #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephankramer
force-pushed
the
reduce-warnings
branch
2 times, most recently
from
48e3d6e to
6eec7a1
Compare
cpjordan
previously approved these changes
Jun 10, 2024
stephankramer
force-pushed
the
reduce-warnings
branch
from
6eec7a1 to
43fa5c0
Compare
1) Don't use Constant(value, domain=mesh). New utility function domain_constant(value, mesh) that creates Function in R space 2) Don't use interpolate(expr, V) (without assemble) instead use Function(V).interpolate(expr)
stephankramer
force-pushed
the
reduce-warnings
branch
3 times, most recently
from
2486c30 to
6e0cda1
Compare
Also hopefully fix CI in tohoku example in a place where we should probably use a domain constant (as it is being assigned to).
stephankramer
force-pushed
the
reduce-warnings
branch
from
6e0cda1 to
4e64c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
domain_constant(value, mesh) that creates Function in R space
Function(V).interpolate(expr)