Fix jupyter notebook demos #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cpjordan
commented
Jan 17, 2024
cpjordan
commented
- Update plot imports from Firedrake
- Update from DumbCheckpoint to CheckpointFile
- Update corresponding text
- Update bathymetry file loading hint on tsunami example
- Update plot imports from Firedrake - Update from DumbCheckpoint to CheckpointFile - Update corresponding text - Update bathymetry file loading hint on tsunami example
|
I think the failure is because I have used a differently named Jupyter kernel locally which alters the notebook metadata. I will re-run the notebooks with the default kernel name and hopefully that fixes this issue. |
jwallwork23
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Thanks very much for this!
I notice you added a new cell at the end of the tsunami demo that describes using CheckpointFile instead of DumbCheckpoint. Would you mind updating the bathymetry file so that it is in the new format? i.e. read with DumbCheckpoint and then overwrite with CheckpointFile? It would be good if we could move away from referring to DumbCheckpoint at all as it was replaced a while ago now.
Would you mind making a couple of other minor changes?
- Drop the "this mesh was actually created using qmesh mentioned in yesterday's lecture" bracket in the tsunami notebook.
- Capitalise Firedrake and Python in both notebooks.
Much appreciated.
- Saved bathy.h5 using CheckpointFile - Made grammar/spelling updates to both .ipynb demos
jwallwork23
approved these changes
Jan 18, 2024
thangel
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.