Use always new eckey on every validation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not keep older EC_KEY on failed attempts. Free them on both failed attempts and successful validation. Allocate key later. Keep just ecsig reused between verifications.
|
It seems to me one could make fail next verification. When I send failing signature, which fails o2i_ECPublicKey() function, it would not release eckey. Next time the same key is reused, even when different algorithm should be used. I think my change fixes it without significant side-effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not keep older EC_KEY on failed attempts. Free them on both failed
attempts and successful validation. Allocate key later. Keep just ecsig
reused between verifications.