feat(iam): support assume role

[JBOClara]

Fix #691

[adejanovski]

Hi @JBOClara,

a few things here:

• There's a lot of noise in this PR due to reformatting of unmodified code, most probably due to your IDE settings. Could you revert these changes so that it's clear what was modified by this PR specifically?
• This comment suggests that there's a simpler solution which would be to construct the client without passing credentials if none are provided. That seems like an interesting option but is not what's done in your PR. What's your opinion on this?

[azman0101]

Hi @JBOClara,

a few things here:

• There's a lot of noise in this PR due to reformatting of unmodified code, most probably due to your IDE settings. Could you revert these changes so that it's clear what was modified by this PR specifically?
• This comment suggests that there's a simpler solution which would be to construct the client without passing credentials if none are provided. That seems like an interesting option but is not what's done in your PR. What's your opinion on this?

Ok, I'll review the formatting.

About the simpler solution, I'm currently implementing it.

I have a hard time mocking the token file /var/run/secrets/eks.amazonaws.com/serviceaccount/token to cover my new code.

[adejanovski]

Hi @JBOClara,
a few things here:

• There's a lot of noise in this PR due to reformatting of unmodified code, most probably due to your IDE settings. Could you revert these changes so that it's clear what was modified by this PR specifically?
• This comment suggests that there's a simpler solution which would be to construct the client without passing credentials if none are provided. That seems like an interesting option but is not what's done in your PR. What's your opinion on this?

Ok, I'll review the formatting.

About the simpler solution, I'm currently implementing it.

I have a hard time mocking the token file /var/run/secrets/eks.amazonaws.com/serviceaccount/token to cover my new code.

I'm confused, you're using two separate github accounts, right? 🙂
Let me know if we can help with your current mocking issues to get this moving forward.

[JBOClara]

I'm confused, you're using two separate github accounts, right? 🙂
Let me know if we can help with your current mocking issues to get this moving forward.

Sorry for the confusion, I'll make sure not to make the mistake again.

I will push my changes to discuss this topic.

[adejanovski]

Sorry for the confusion, I'll make sure not to make the mistake again.

I will push my changes to discuss this topic.

No worries, thanks!

[adejanovski]

Changes look good and I was able to successfully test them using a role attached to an ec2 instance 👍

Issue: CI is failing due to formatting issues detected by flake8. See here.
Once these are fixed and CI passes, we'll be good for a merge.
Thanks!

[sonarqubecloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[adejanovski]

Awesome stuff, thanks @JBOClara 🙏