-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to enable ingest old data #87
Merged
rossf7
merged 12 commits into
thegreenwebfoundation:main
from
aknostic:document-enable-ingest-old-data
Aug 29, 2024
Merged
Document how to enable ingest old data #87
rossf7
merged 12 commits into
thegreenwebfoundation:main
from
aknostic:document-enable-ingest-old-data
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegreenwebfoundation#81 - Now sending always the timestamp in the Prometheus metrics. - For ElectricityMaps, we now use the historic endpoint instead of the carbon-intensity one, so we can get both the latest estimated and real values. - Tested that it works with Ember and CarbonIntensityOrgUK, Watttime not yet (I need to register) - The label is_estimated has been added in the Prometheus metrics. For ElectricityMaps it can provide values for both, or for one of the two, depending on the location. - For the other providers it always returns the value as is_estimated=false (the default) because I didn't make any changes. I'm. not 100% sure this is correct for all of them, or if some of the providers also return estimations (to investigate). - The error handling when parsing generates a lot of clutter, not sure if there's a better way to do it in go...
for relative carbon intensity Otherwise we see this error, for example: panic: inconsistent label cardinality: expected 5 label values but got 6 in []string{"CAISO_NORTH", "", "WattTime", "", "percent", "false"}
Thus, we are setting IsEstimated to true. See for more info thegreenwebfoundation#83 (comment)
Co-authored-by: Ross Fairbanks <[email protected]>
in Prometheus. Related to PR thegreenwebfoundation#83 "For the Prometheus exporter, the values based on ElecticityMaps provider are estimations and not the real values"
@rossf7 This is what we discussed a while ago - it took me a bit of time to actually make the PR, with the holidays in the middle... |
rossf7
reviewed
Aug 29, 2024
rossf7
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@locomundo thank you for following up on this!
Co-authored-by: Ross Fairbanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds some documentation about how to allow your Prometheus to ingest "old" data. It's a follow up of this PR 83 and intended to avoid people having this issue.
Basically we want to avoid Prometheus failing to ingest "old" data from ElectricityMaps. In those cases you will see this error:
Error on ingesting samples that are too old or are too far into the future