un-SCL-ify hammer-cli-katello

[ianballou]

Makes the hammer-cli-katello spec file no longer use ye olde SCL macros from the EL7 days.

[ekohl]

We should look at the autorequires. This may be redundant but then we need to update the template too.

[ekohl]

Looking again, I think you did this by hand. In 3f4c042 we redid this section to rely on autorequires.

Suggested change

	Requires: rubygem(hammer_cli_foreman)
	Requires: rubygem(hammer_cli_foreman_tasks)

While we're on the topic of updates, in 10e0424 we started to add Provides for plugins. Could you add that too?

[ekohl]

I'd like to point out (once again) that since Katello/hammer-cli-katello#924 the nightly packages have been broken: https://ci.theforeman.org/blue/organizations/jenkins/hammer-cli-katello-master-source-release/detail/hammer-cli-katello-master-source-release/204/pipeline

Given they've been broken for 3 months, can we assume they're not tested anyway and we can change it regular gems?

[ianballou]

Given they've been broken for 3 months, can we assume they're not tested anyway and we can change it regular gems?

There is a testing queue for hammer-cli-katello issues that has built up over the 3 months, but it's small enough for people not to be clamoring about it. We would like to keep the h-c-k nightlies going. Last I heard, Zach was taking a look.

[ekohl]

You'll need to recreate Gemfile and define a testing group. Jenkins now doesn't install the development group

[ianballou]

I added a test group to https://github.com/Katello/hammer-cli-katello/pull/934/files

[ianballou]

Let's merge #10767 first to unblock nightly if this PR still has issues.

[evgeni]

Suggested change

	gem build ../%{gem_name}-%{version}.gemspec
	gem build ../%{gem_name}-%{version}%{?prerelease}.gemspec

I think that's the last place missing prerelease.

[ekohl]

I think this is automatic nowadays and was dropped in 3f4c042

[ekohl]

Looking again, I think you did this by hand. In 3f4c042 we redid this section to rely on autorequires.

Suggested change

	Requires: rubygem(hammer_cli_foreman)
	Requires: rubygem(hammer_cli_foreman_tasks)

While we're on the topic of updates, in 10e0424 we started to add Provides for plugins. Could you add that too?

[ianballou]

@ekohl to address the comments about items being different from what the spec automation provides, I rebased, regenerated the entire spec file, and added back in the nightly bits.

[ianballou]

[2024-05-15T20:58:50.452Z] TASK [Check for a new changelog entry] *****************************************

[2024-05-15T20:58:50.452Z] fatal: [rubygem-hammer_cli_katello]: FAILED! => 

[2024-05-15T20:58:50.452Z]     changed: false

[2024-05-15T20:58:50.452Z]     changelog_epoch_version_release: ''

[2024-05-15T20:58:50.452Z]     msg: Could not find specfile

[2024-05-15T20:58:50.452Z]     specfile_epoch_version_release: ''

I'm unsure why the specfile cannot be found.

[evgeni]

It added another hammer cli katello to plugins in comps/manifest, that confuses it.

[evgeni]

I've dropped those additional entries and it built \o/

@ekohl mind having another look?