Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DHCPv6 server requirement #3541

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Dec 23, 2024

What changes are you introducing?

Updating the requirement for the IPv6 DHCP server

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Satellite 6.17 has to comply with US Gov. requirement for IPv6 support

IPv6 is not limited to GRUB2 anymore and will use a different DHCP provider in future. Therefore, dropping mentions of those specifics from the wording.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Related to #3532

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: N/A

@Lennonka Lennonka changed the title Update DHVPv6 server requirement Update DHCPv6 server requirement Dec 23, 2024
@ShimShtein
Copy link
Member

LGTM

@Lennonka Lennonka added tech review done No issues from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Dec 25, 2024
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small suggestions on the wording.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for generalizing this. It would be nice to have specific instructions on how to set it up, but this is an improvement.

@asteflova asteflova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 6, 2025
@ekohl
Copy link
Member

ekohl commented Jan 6, 2025

It would be nice to have specific instructions on how to set it up, but this is an improvement.

Answering my own question: you added it in https://github.com/theforeman/foreman-documentation/pull/3532/files#diff-ea0eadfa09f357fdaa6cab9283b0bed65a08acd7163644ad129e6f2eed86334c so would it make sense to link to it?

@Lennonka
Copy link
Contributor Author

Lennonka commented Jan 6, 2025

Rebased.

@Lennonka Lennonka merged commit f85a130 into theforeman:master Jan 9, 2025
9 checks passed
@Lennonka Lennonka deleted the update-ipv6-reqs branch January 9, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants