-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DHCPv6 server requirement #3541
Conversation
The PR preview for e070013 is available at theforeman-foreman-documentation-preview-pr-3541.surge.sh The following output files are affected by this PR: |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small suggestions on the wording.
guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for generalizing this. It would be nice to have specific instructions on how to set it up, but this is an improvement.
guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc
Outdated
Show resolved
Hide resolved
Answering my own question: you added it in https://github.com/theforeman/foreman-documentation/pull/3532/files#diff-ea0eadfa09f357fdaa6cab9283b0bed65a08acd7163644ad129e6f2eed86334c so would it make sense to link to it? |
Co-authored-by: Maximilian Kolb <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
e312f2f
to
3f0be2f
Compare
Rebased. |
guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc
Outdated
Show resolved
Hide resolved
…ipv6-network.adoc
What changes are you introducing?
Updating the requirement for the IPv6 DHCP server
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Satellite 6.17 has to comply with US Gov. requirement for IPv6 support
IPv6 is not limited to GRUB2 anymore and will use a different DHCP provider in future. Therefore, dropping mentions of those specifics from the wording.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Related to #3532
Checklists
Please cherry-pick my commits into: N/A