Publish Administering Foreman for all flavours #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliankolb
added
Needs tech review
maximiliankolb
added this to the Make foreman-documentation the primary upstream documentation milestone
|
The PR preview for f515aef is available at theforeman-foreman-documentation-preview-pr-3515.surge.sh The following output files are affected by this PR: |
maximiliankolb
commented
Dec 11, 2024
guides/common/modules/proc_viewing-general-smart-proxy-information.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_viewing-general-smart-proxy-information.adoc
Outdated
Show resolved
Hide resolved
Lennonka
reviewed
Dec 17, 2024
There was a problem hiding this comment.
LGTM and I agree with your suggestions.
However, it might be something for @ekohl to look at to check that modules and bits are hidden correctly.
I agree that Vale errors are out of scope. Perhaps create issues to fix them globally? Eg. Fix Vale error "hostgroup" -> "host group", etc.
maximiliankolb
added
style review done
maximiliankolb
force-pushed
the
administering_foreman
branch
from
dafd61d to
33d4de0
Compare
maximiliankolb
commented
Dec 18, 2024
guides/common/modules/proc_viewing-general-smart-proxy-information.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_viewing-general-smart-proxy-information.adoc
Outdated
Show resolved
Hide resolved
maximiliankolb
force-pushed
the
administering_foreman
branch
from
33d4de0 to
0ec0c12
Compare
nadjaheitmann
approved these changes
Jan 10, 2025
maximiliankolb
added
tech review done
* Estimate disk usage for backups is Katello-only * Backups without Pulp are Katello-only * Hide Pulp database for Foreman because it's Katello-only * Do not sync content to Smart Proxy Servers for Foreman Content on Smart Proxy Servers is Katello-only. * Hide Katello-specific events for Foreman * Hide Katello-specific settings for Foreman * Hide Pulp for non-Katello * Hide Pulp mirror for Foreman * Show content and content settings for Katello only closes 676
maximiliankolb
force-pushed
the
administering_foreman
branch
from
0ec0c12 to
f515aef
Compare
maximiliankolb
added a commit
that referenced
this pull request
Jan 10, 2025
* Estimate disk usage for backups is Katello-only * Backups without Pulp are Katello-only * Hide Pulp database for Foreman because it's Katello-only * Do not sync content to Smart Proxy Servers for Foreman Content on Smart Proxy Servers is Katello-only. * Hide Katello-specific events for Foreman * Hide Katello-specific settings for Foreman * Hide Pulp for non-Katello * Hide Pulp mirror for Foreman * Show content and content settings for Katello only closes 676 (cherry picked from commit e5cc763)
maximiliankolb
added a commit
that referenced
this pull request
Jan 10, 2025
* Estimate disk usage for backups is Katello-only * Backups without Pulp are Katello-only * Hide Pulp database for Foreman because it's Katello-only * Do not sync content to Smart Proxy Servers for Foreman Content on Smart Proxy Servers is Katello-only. * Hide Katello-specific events for Foreman * Hide Katello-specific settings for Foreman * Hide Pulp for non-Katello * Hide Pulp mirror for Foreman * Show content and content settings for Katello only closes 676 (cherry picked from commit e5cc763)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
closes 676
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: