-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten procedures to configure hosts on Proxmox in WebUI #3176
Conversation
@Manisha15 Can you please verify this/do a technical review? |
The PR preview for 15ea48a is available at theforeman-foreman-documentation-preview-pr-3176.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few style comments. I love seeing PRs that shorten long procedures!!!!
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
e36700e
to
15ea48a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied most feedback and rebased to "master". I consider the two remaining open threads out of scope and would keep it as is for now.
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_adding-proxmox-details-to-a-compute-profile.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The Vale check is a false positive and can be ignored.
Refs theforeman/foreman_fog_proxmox#331
Do not cherry-pick.