Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten procedures to configure hosts on Proxmox in WebUI #3176

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

maximiliankolb
Copy link
Contributor

Refs theforeman/foreman_fog_proxmox#331

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Do not cherry-pick.

@maximiliankolb
Copy link
Contributor Author

@Manisha15 Can you please verify this/do a technical review?

Copy link
Contributor

@apinnick apinnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style comments. I love seeing PRs that shorten long procedures!!!!

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Jul 31, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Aug 2, 2024
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied most feedback and rebased to "master". I consider the two remaining open threads out of scope and would keep it as is for now.

Copy link
Contributor

@apinnick apinnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Vale check is a false positive and can be ignored.

@apinnick apinnick added Needs tech review Requires a review from the technical perspective style review done No issues from docs style/grammar perspective labels Aug 4, 2024
@maximiliankolb maximiliankolb merged commit 3dd0140 into theforeman:master Aug 5, 2024
8 of 9 checks passed
@maximiliankolb maximiliankolb deleted the proxmox_webui branch August 5, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs tech review Requires a review from the technical perspective style review done No issues from docs style/grammar perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants