Skip to content

Commit

Permalink
Merge remote-tracking branch 'aosp/jb-release' into jb
Browse files Browse the repository at this point in the history
Conflicts:
	src/com/android/settings/DeviceInfoSettings.java

Change-Id: Ia519bc98b78d8bb7910c5b51c8cc155f307431c0
  • Loading branch information
xoomdev committed Sep 23, 2012
2 parents ddb36ed + 8272edb commit f8b09c6
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1802,6 +1802,8 @@
<string name="firmware_version">Android version</string>
<!-- About phone screen, status item label-->
<string name="model_number">Model number</string>
<!-- About phone screen, fcc equipment id label-->
<string name="fcc_equipment_id">Equipment ID</string>
<!-- About phone screen, setting option name-->
<string name="baseband_version">Baseband version</string>
<!-- About phone screen, setting option name-->
Expand Down
6 changes: 6 additions & 0 deletions res/xml/device_info_settings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,12 @@
style="?android:preferenceInformationStyle"
android:title="@string/firmware_version"
android:summary="@string/device_info_default"/>

<!-- Device FCC equipment id -->
<Preference android:key="fcc_equipment_id"
style="?android:preferenceInformationStyle"
android:title="@string/fcc_equipment_id"
android:summary="@string/device_info_default"/>

<!-- Device Baseband version -->
<Preference android:key="baseband_version"
Expand Down
8 changes: 8 additions & 0 deletions src/com/android/settings/DeviceInfoSettings.java
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment {
private static final String KEY_DEVICE_REAR_CAMERA = "device_rear_camera";
private static final String KEY_DEVICE_FRONT_CAMERA = "device_front_camera";
private static final String KEY_DEVICE_SCREEN_RESOLUTION = "device_screen_resolution";
private static final String KEY_EQUIPMENT_ID = "fcc_equipment_id";
private static final String PROPERTY_EQUIPMENT_ID = "ro.ril.fccid";

long[] mHits = new long[3];

Expand All @@ -82,6 +84,8 @@ public void onCreate(Bundle icicle) {
findPreference(KEY_FIRMWARE_VERSION).setEnabled(true);
setValueSummary(KEY_BASEBAND_VERSION, "gsm.version.baseband");
setStringSummary(KEY_DEVICE_MODEL, Build.MODEL + getMsvSuffix());
setValueSummary(KEY_EQUIPMENT_ID, PROPERTY_EQUIPMENT_ID);
setStringSummary(KEY_DEVICE_MODEL, Build.MODEL);
setStringSummary(KEY_BUILD_NUMBER, Build.DISPLAY);
setStringSummary(KEY_KERNEL_VERSION, getFormattedKernelVersion());
findPreference(KEY_KERNEL_VERSION).setEnabled(true);
Expand All @@ -104,6 +108,10 @@ public void onCreate(Bundle icicle) {
removePreferenceIfPropertyMissing(getPreferenceScreen(), "safetylegal",
PROPERTY_URL_SAFETYLEGAL);

// Remove Equipment id preference if FCC ID is not set by RIL
removePreferenceIfPropertyMissing(getPreferenceScreen(), KEY_EQUIPMENT_ID,
PROPERTY_EQUIPMENT_ID);

// Remove Baseband version if wifi-only device
if (Utils.isWifiOnly(getActivity())) {
getPreferenceScreen().removePreference(findPreference(KEY_BASEBAND_VERSION));
Expand Down

0 comments on commit f8b09c6

Please sign in to comment.