Skip to content

Commit

Permalink
Display FCC id for LTE in Settings.
Browse files Browse the repository at this point in the history
If ro.ril.fccid is set by RIL, display it at Settings -> About Tablet -> FCC Equipment ID.

bug:4965501
Change-Id: I920ab071bf1997c4fbf3ce81f88e24f512d004c3
  • Loading branch information
John Wang authored and The Android Automerger committed Jul 13, 2012
1 parent e413019 commit be58470
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1768,6 +1768,8 @@
<string name="firmware_version">Android version</string>
<!-- About phone screen, status item label-->
<string name="model_number">Model number</string>
<!-- About phone screen, fcc equipment id label-->
<string name="fcc_equipment_id">Equipment ID</string>
<!-- About phone screen, setting option name-->
<string name="baseband_version">Baseband version</string>
<!-- About phone screen, setting option name-->
Expand Down
6 changes: 6 additions & 0 deletions res/xml/device_info_settings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@
style="?android:preferenceInformationStyle"
android:title="@string/firmware_version"
android:summary="@string/device_info_default"/>

<!-- Device FCC equipment id -->
<Preference android:key="fcc_equipment_id"
style="?android:preferenceInformationStyle"
android:title="@string/fcc_equipment_id"
android:summary="@string/device_info_default"/>

<!-- Device Baseband version -->
<Preference android:key="baseband_version"
Expand Down
8 changes: 8 additions & 0 deletions src/com/android/settings/DeviceInfoSettings.java
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment {
private static final String KEY_BASEBAND_VERSION = "baseband_version";
private static final String KEY_FIRMWARE_VERSION = "firmware_version";
private static final String KEY_UPDATE_SETTING = "additional_system_update_settings";
private static final String KEY_EQUIPMENT_ID = "fcc_equipment_id";
private static final String PROPERTY_EQUIPMENT_ID = "ro.ril.fccid";

long[] mHits = new long[3];

Expand All @@ -72,13 +74,19 @@ public void onCreate(Bundle icicle) {
findPreference(KEY_FIRMWARE_VERSION).setEnabled(true);
setValueSummary(KEY_BASEBAND_VERSION, "gsm.version.baseband");
setStringSummary(KEY_DEVICE_MODEL, Build.MODEL + getMsvSuffix());
setValueSummary(KEY_EQUIPMENT_ID, PROPERTY_EQUIPMENT_ID);
setStringSummary(KEY_DEVICE_MODEL, Build.MODEL);
setStringSummary(KEY_BUILD_NUMBER, Build.DISPLAY);
findPreference(KEY_KERNEL_VERSION).setSummary(getFormattedKernelVersion());

// Remove Safety information preference if PROPERTY_URL_SAFETYLEGAL is not set
removePreferenceIfPropertyMissing(getPreferenceScreen(), "safetylegal",
PROPERTY_URL_SAFETYLEGAL);

// Remove Equipment id preference if FCC ID is not set by RIL
removePreferenceIfPropertyMissing(getPreferenceScreen(), KEY_EQUIPMENT_ID,
PROPERTY_EQUIPMENT_ID);

// Remove Baseband version if wifi-only device
if (Utils.isWifiOnly(getActivity())) {
getPreferenceScreen().removePreference(findPreference(KEY_BASEBAND_VERSION));
Expand Down

0 comments on commit be58470

Please sign in to comment.