Handle subclasses of PolymorphicModel being abstract #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was an abstract model in between a concrete subclass and it's
PolymorphicModel
class, the admin would not allow the child model to be moved because it was not in the allowed "childModels" being passed to the frontend.For example the following would break:
Before, the only valid child models passed to the frontend would be
DirectPolymorphicChild
andAbstractBase
. This meant thatChildOfAbstract
andChildOfAbstract2
could be added to the admin, but were blocked from being moved around.Added a test app to verify this change and show that now having an abstract class doesn't break the admin.