-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many fixes #145
base: master
Are you sure you want to change the base?
Many fixes #145
Conversation
@juherr why rename the group ID? would it impact the CI build as the credentials may tie with group ID |
It looks more commons to have all modules under the same groupId. I think the delivery at central is the good time to change it. The credentials are able to deploy everything under groupid org.testng or children. |
Btw, feel free to cherry pick some commits because I'm not sure that all are a good idea. |
@missedone - So we are cherry picking the needed commits from this PR ? Please let me know. |
Yes, changing the group ID and artifact ID may break several things, even though I assume only testng eclipse plugin use testng-remote, however, I think it's better to keep the compatibility in case somebody else uses it as well |
@juherr @krmahadevan are you good with releasing |
@missedone - I am not that familiar with the |
@missedone sure, go ahead |
For review, comments and feedbacks