Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many fixes #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Many fixes #145

wants to merge 2 commits into from

Conversation

juherr
Copy link
Member

@juherr juherr commented Jun 5, 2023

For review, comments and feedbacks

@juherr juherr requested review from missedone and krmahadevan June 5, 2023 21:03
@juherr juherr requested a review from a team as a code owner June 5, 2023 21:03
@missedone
Copy link
Contributor

@juherr why rename the group ID? would it impact the CI build as the credentials may tie with group ID org.testng, we shall test out soon

@juherr
Copy link
Member Author

juherr commented Jun 5, 2023

It looks more commons to have all modules under the same groupId.
I don't remember why we didn't do it directly.

I think the delivery at central is the good time to change it.

The credentials are able to deploy everything under groupid org.testng or children.

@juherr
Copy link
Member Author

juherr commented Jun 5, 2023

Btw, feel free to cherry pick some commits because I'm not sure that all are a good idea.

@missedone missedone mentioned this pull request Jun 6, 2023
@krmahadevan
Copy link
Member

@missedone - So we are cherry picking the needed commits from this PR ? Please let me know.

@missedone
Copy link
Contributor

Yes, changing the group ID and artifact ID may break several things, even though I assume only testng eclipse plugin use testng-remote, however, I think it's better to keep the compatibility in case somebody else uses it as well

@missedone
Copy link
Contributor

@juherr @krmahadevan are you good with releasing 1.5.0 use current master HEAD?
(I need to test if the release github actions workflow works or not, no way to dry-run :) )

@krmahadevan
Copy link
Member

@missedone - I am not that familiar with the testng-remote codebase to be able to answer that question.
So I would leave the decision to you :)

@juherr
Copy link
Member Author

juherr commented Jun 6, 2023

@missedone sure, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants