Move TrajOptIfopt collision gradient types and utils to trajopt_common package #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
feat/MoveTrajoptIfoptCollisionUtils
branch
from
8fce650 to
91c809c
Compare
|
Looks good! I've done some testing, and this works with the Ifopt version of the basic_cartesian_example. But when fixing a mistake in my Ifopt adaptation of the car_seat_example, I got a crash, both in this branch and in the old version. I have tracked it down to this line, where the |
|
I think you can merge this. And tesseract_planning needs only minor modifications to support this. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rjoomen