removes lookup for existing routers

terraform-google-modules · Oct 18, 2023 · 4a8f590 · 4a8f590
1 parent 9ee554f
commit 4a8f590
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/modules/vpn_ha/main.tf b/modules/vpn_ha/main.tf
@@ -18,7 +18,7 @@
 locals {
   router = (
     var.router_name == ""
-    ? google_compute_router.router[0].name
+    ? google_compute_router.router.name
     : var.router_name
   )
   peer_external_gateway = (
@@ -61,16 +61,8 @@ resource "google_compute_external_vpn_gateway" "external_gateway" {
   }
 }
 
-data "google_compute_router" "router" {
-  name    = var.router_name == null ? "" : var.router_name
-  network = var.network
-  project = var.project_id
-  region  = var.region
-}
-
 resource "google_compute_router" "router" {
-  provider = google-beta
-  count    = data.google_compute_router.router.name == null ? 1 : 0
+  provider = google-beta  
   name     = var.router_name != "" ? var.router_name : "vpn-${var.name}"
   project  = var.project_id
   region   = var.region

diff --git a/modules/vpn_ha/outputs.tf b/modules/vpn_ha/outputs.tf
@@ -35,7 +35,7 @@ output "name" {
 
 output "router" {
   description = "Router resource (only if auto-created)."
-  value       = var.router_name == "" ? google_compute_router.router[0] : null
+  value       = var.router_name == "" ? google_compute_router.router : null
 }
 
 output "router_name" {