-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Version bump workflows #180
ci: Version bump workflows #180
Conversation
Hi @polarathene , Thank you for your pull request! Your contribution is much appreciated. 😄 I noticed that the CI tests have failed for this pull request due of linting upgrade. can you please take a look? |
This comment was marked as outdated.
This comment was marked as outdated.
7059b42
to
72d9914
Compare
Ready for you to run the CI again 👍 |
I noticed that you made modifications to the files within the vendor/* directory. Regrettably, we cannot accept any additions or alterations in this folder due to security concerns. Our objective is to maintain the integrity of the libraries contained therein, as these libraries are sourced from third-party vendors and should not be subject to any changes. |
I am not a Go dev, you're asking me to make changes beyond the Github Actions workflow files 🤷♂️
EDIT: Nevermind, lazy attempt to revert |
I'm still seeing changes in vendor folder |
a891bb1
to
409ce54
Compare
Yeah, sorry about that. Some already had |
If the workflows pass and everything looks good, you may want to wait just a little longer to cover that as well? |
@polarathene yes it will be great to fix the linting step |
You do it. Sorry, but I contributed the PR with no response for 3 weeks, then addressed the review feedback. Tests passed at the time. It's been over 4 months since then, I am not responsible for that drift. Versions that are bumped in this PR have likely changed since and should be bumped appropriately. I don't use this project, so feel free to update the PR or close it 🤷♂️ |
Related Issues
N/A
Description
Overall, version bumps from most releases in March 2022 to those available in August 2023. Does not appear to introduce any breaking changes that would affect the workflows.
goreleaser/goreleaser-action
is at v4 (the last v2 release was March 2022). Likewise thegorelease
version has been bumped from1.7
(March 2022) to1.20
(August 2023).golangci/golangci-lint-action
is at 3.7, butgolangci-lint
version is presently1.54
. The current1.45
release is from March 2022.spectralops/spectral-github-action
v1 was Jan 2022, while Jun 2023 released v4.actions/setup-go
bumped tov4
). Go updated to1.21
(Aug 2023) from1.18
(Mar 2022).actions/checkout
to v4 (Sep 2023).Motivation and Context
There was a minor update in April 2023 to a workflow, but I felt that the project would benefit from not letting the workflows become stale. At a glance, it doesn't look like there is any breaking changes introduced by any of the dependencies receiving a version bump.
As releases will be built via these workflows, it'd be nice to have them built with a more recent or latest version of Go.
How Has This Been Tested?
I've not tried running these updated workflows via a fork, but the change should be fairly straight-forward / harmless?