Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Version bump workflows #180

Conversation

polarathene
Copy link

@polarathene polarathene commented Aug 30, 2023

Related Issues

N/A

Description

Overall, version bumps from most releases in March 2022 to those available in August 2023. Does not appear to introduce any breaking changes that would affect the workflows.

Motivation and Context

There was a minor update in April 2023 to a workflow, but I felt that the project would benefit from not letting the workflows become stale. At a glance, it doesn't look like there is any breaking changes introduced by any of the dependencies receiving a version bump.

As releases will be built via these workflows, it'd be nice to have them built with a more recent or latest version of Go.

How Has This Been Tested?

I've not tried running these updated workflows via a fork, but the change should be fairly straight-forward / harmless?

@polarathene polarathene mentioned this pull request Aug 30, 2023
@kaplanelad
Copy link
Contributor

Hi @polarathene ,

Thank you for your pull request! Your contribution is much appreciated. 😄

I noticed that the CI tests have failed for this pull request due of linting upgrade. can you please take a look?

@polarathene

This comment was marked as outdated.

@polarathene polarathene force-pushed the ci/version-bump-workflows-aug23 branch from 7059b42 to 72d9914 Compare September 20, 2023 05:16
@polarathene
Copy link
Author

can you please take a look?

Ready for you to run the CI again 👍

@kaplanelad
Copy link
Contributor

I noticed that you made modifications to the files within the vendor/* directory. Regrettably, we cannot accept any additions or alterations in this folder due to security concerns. Our objective is to maintain the integrity of the libraries contained therein, as these libraries are sourced from third-party vendors and should not be subject to any changes.

@polarathene
Copy link
Author

polarathene commented Sep 20, 2023

Regrettably, we cannot accept any additions or alterations in this folder due to security concerns.

I am not a Go dev, you're asking me to make changes beyond the Github Actions workflow files 🤷‍♂️

  • I've reverted the modification to vendor/. I don't know your merge policy, so if you need that squashed I can accommodate.
  • Workflow should be fine to run for now to verify everything else is fine?

EDIT: Nevermind, lazy attempt to revert vendor by me. I'll resolve that.

@kaplanelad
Copy link
Contributor

I'm still seeing changes in vendor folder

@polarathene polarathene force-pushed the ci/version-bump-workflows-aug23 branch from a891bb1 to 409ce54 Compare September 20, 2023 07:03
@polarathene
Copy link
Author

I'm still seeing changes in vendor folder

Yeah, sorry about that. Some already had //nolint. Resolved properly.

@polarathene
Copy link
Author

goreleaser/goreleaser-action has a v5 release now (nothing too important there, mostly a bump in NodeJS to v20 like many other actions are doing recently), and within a couple days it looks like goreleaser will also have a 1.21 release out.

If the workflows pass and everything looks good, you may want to wait just a little longer to cover that as well?

@kaplanelad
Copy link
Contributor

@polarathene yes it will be great to fix the linting step

@polarathene
Copy link
Author

polarathene commented Jan 23, 2024

@polarathene yes it will be great to fix the linting step

You do it.

Sorry, but I contributed the PR with no response for 3 weeks, then addressed the review feedback. Tests passed at the time. It's been over 4 months since then, I am not responsible for that drift.

Versions that are bumped in this PR have likely changed since and should be bumped appropriately. I don't use this project, so feel free to update the PR or close it 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants