Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add utility to err on unreachable branches #991

Merged
merged 1 commit into from
Nov 11, 2024
Merged

refactor: add utility to err on unreachable branches #991

merged 1 commit into from
Nov 11, 2024

Conversation

verytactical
Copy link
Contributor

@verytactical verytactical commented Oct 28, 2024 •
edited
Loading

Issue

Closes #915.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@verytactical verytactical requested a review from a team as a code owner October 28, 2024 14:45
@anton-trunov
Copy link
Member

It would be nice to add some usage examples for the new utilities

novusnota
novusnota reviewed Oct 30, 2024
View reviewed changes
src/interpreter.ts Outdated Show resolved Hide resolved
@anton-trunov
Copy link
Member

Perhaps let's try applying it to the map key/value pair types once #993 is merged

@anton-trunov anton-trunov self-assigned this Nov 6, 2024
@anton-trunov anton-trunov added this to the v1.6.0 milestone Nov 6, 2024
anton-trunov
anton-trunov requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert changes on switch which are not strictly necessary and keep them only for pairs of key/value types where exhaustivity is desired

src/interpreter.ts Outdated Show resolved Hide resolved
src/generator/writers/writeStdlib.ts Outdated Show resolved Hide resolved
@anton-trunov
Copy link
Member

CI is not all green

@anton-trunov anton-trunov merged commit bb25297 into main Nov 11, 2024
17 checks passed
@anton-trunov anton-trunov deleted the tact-915 branch November 11, 2024 18:28
github-actions bot pushed a commit to TownSquareXYZ/tact that referenced this pull request Nov 12, 2024
@verytactical @github-actions
refactor: add utility to err on unreachable branches (tact-lang#991)
d7a5202 
and use it in pattern matching over all key/value map type pairs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota left review comments

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Improve exhaustiveness checks
3 participants
@verytactical @anton-trunov @novusnota