-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance error handling to support third-party tools #509
Enhance error handling to support third-party tools #509
Conversation
- Replaced consoleLogger with the new Logger - Removed jest mock where consoleLogger was used - Improved support for third-party tools
Any progress here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait for @byakuren-hijiri to approve
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's refactor existing sources a little bit and fix the operations with paths to avoid cross-platform problems. After that, LGTM.
I just pushed two fixes, let's see if the tests are green and merge it |
Closes #262
[ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER[ ] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases