Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Equality on addresses, slices, cells. #1279

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

jeshecdom
Copy link
Contributor

Issue

Towards #539.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@jeshecdom jeshecdom requested a review from a team as a code owner January 3, 2025 10:24
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, just some minor comments


/*************** Cells ********************/

get fun testCellEquality(): Bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add tests for cells obtained in a different way, not just from structs

@anton-trunov anton-trunov requested a review from novusnota January 3, 2025 11:47
@anton-trunov anton-trunov self-assigned this Jan 5, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 5, 2025
novusnota and others added 4 commits January 6, 2025 16:41
…rentContract())`

And small updates of similar descriptions on the Operators page of the
Book
Added tests of equality of cells manually built using builders (with cells having references and without).
@anton-trunov anton-trunov merged commit 408995b into main Jan 8, 2025
18 checks passed
@anton-trunov anton-trunov deleted the semantics-test branch January 8, 2025 04:02
xpyctumo pushed a commit that referenced this pull request Jan 13, 2025
* Semantics tests for equality on addresses, slices, cells

* feat(docs): equality of `myAddress()` and `contractAddress(initOf CurrentContract())`

And small updates of similar descriptions on the Operators page of the
Book

* Tests of equality of slices with references to cells

* Tests of equality of cells manually built using builders (with cells having references and without)

---------

Co-authored-by: Novus Nota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants