MOB-3869-Add a sample screen to example app of API customization #6

DanielFrTB · 2025-01-08T12:36:29Z

CTA button visibility API
DarkMode colors example ( working with OS)
Font
Line space
Number of lines

Java:

Kotlin:

Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/MetaAdUICustomization.java

tomer-br-taboola · 2025-01-08T13:31:49Z

Java/app/src/main/java/com/taboola/sdk4example/SDKClassicMenuFragment.java

@@ -115,6 +119,12 @@ public void onClick(View v) {
            case R.id.std_meta_classic_unit:
                fragmentToOpen = new MetaClassicUnitFragment();
                break;
+            case R.id.std_meta_ad_UI_customization:


@DanielFrTB - What is the difference between these two screens?

@tomer-br-taboola
std_meta_ad_UI_customization - regular Meta ad
std_meta_tbl_classic_unit_ad_UI_customization - meta_tbl_classic_unit (1x1 + feed)

tomer-br-taboola · 2025-01-08T13:32:38Z

Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/MetaAdUICustomization.java

+            }
+        });
+        tblClassicUnit.setUnitExtraProperties(new HashMap<String, String>() {{
+            put(MetaConst.AUDIENCE_NETWORK_PLACEMENT_ID_KEY, MetaConst.AUDIENCE_NETWORK_CAROUSEL_PLACEMENT_ID);


@DanielFrTB - Is there a reason why you chose a carousel placement id here?

@tomer-br-taboola
No, Changed to DEFAULT_LAYOUT_KEY

tomer-br-taboola · 2025-01-08T13:33:08Z

Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/MetaAdUICustomization.java

+                .setFontSize(TEXT_FONT_SIZE)
+                .setFontDarkColor(Color.BLUE)
+                .build();
+        TBLUiStyleProperties ctaStyleProperties = new TBLCallToActionButtonStylePropertiesBuilder()


@DanielFrTB - Since the default setting for the CTA button is to be visible, what is the point of showing this?

@tomer-br-taboola
I think that we need to display the all API we have.

I can remove if needed

@DanielFrTB - If you want to display all the APIs we have, choose an option that shows to publishers how it works. This way, publishers might think they need to do this (even though they don't since the default is to show the CTA button).

tomer-br-taboola · 2025-01-08T13:33:42Z

...rc/main/java/com/taboola/sdk4example/sdk_classic/MetaClassicUnitFragmentUICustomization.java

+        tblMetaClassicUnit.setUnitExtraProperties(new HashMap<String, String>() {{
+            put(MetaConst.AUDIENCE_NETWORK_PLACEMENT_ID_KEY, MetaConst.AUDIENCE_NETWORK_PLACEMENT_ID);
+        }});
+        TBLUiStyleProperties brandingStyleProperties = new TBLTextStylePropertiesBuilder(ELEMENT_TYPE_BRANDING)


@DanielFrTB - Comments from the previous screen also apply here.

tomer-br-taboola · 2025-01-08T13:34:51Z

Java/app/src/main/java/com/taboola/sdk4example/MetaConst.java

@@ -12,4 +12,10 @@ public class MetaConst {
    public static final String DEFAULT_LAYOUT_KEY = "default";
    public static final String TEST_LAYOUT_IMAGE_LINK_TYPE = "image_link";
    public static final String TEST_LAYOUT_CAROUSEL_TYPE = "carousel";
+    // UI customization
+    public static final String ELEMENT_TYPE_BRANDING = "branding";
+    public static final String DARK_NODE = "darkMode";


@DanielFrTB - Why is the dark mode key part of the UI Customizations here and not in the Kotlin part?

@tomer-br-taboola aligned

tomer-br-taboola · 2025-01-08T13:35:54Z

.../src/main/java/com/taboola/kotlin/examples/screens/classic/MetaAdUICustomizationsFragment.kt

+                    Log.d(MetaAdUICustomizationsFragment.TAG, "onAdReceiveFail $error")
+                }
+            })
+        tblClassicUnit.setAdTypeForDebug(MetaConst.TEST_LAYOUT_IMAGE_LINK_TYPE)


@DanielFrTB - I think that in these screens (as well as the Java counterparts), comments can help publishers understand what is going on.

tomer-br-taboola

Please go over the comments.

tomer-br-taboola · 2025-01-09T10:17:04Z

Java/app/src/main/java/com/taboola/sdk4example/MetaConst.java

+    // UI customization
+    public static final String ELEMENT_TYPE_BRANDING = "branding";
+    public static final String DARK_NODE = "darkMode";
+    public static final String FONT_TYPEFACE_ARIAL_BOLD = "arial_bold";


@DanielFrTB - No need to write typeface and font. Choose one and stick to it.

tomer-br-taboola · 2025-01-09T10:18:51Z

Java/app/src/main/java/com/taboola/sdk4example/MetaConst.java

+    public static final String FONT_TYPEFACE_ARIAL_BOLD = "arial_bold";
+    public static final int TEXT_FONT_SIZE = 20;
+    public static final int NUMBER_OF_LINES = 2;
+    public static final float AMOUNT_OF_LINES_BETWEEN_LINES = 0.5f;


@DanielFrTB - I think the name of this constant is wrong, AMOUNT_OF_LINES_BETWEEN_LINES. I believe it should be amount of space between lines.
https://brain.taboola.com/display/MOBILE/TBLUiStyleProperties

tomer-br-taboola · 2025-01-09T10:19:35Z

Java/app/src/main/java/com/taboola/sdk4example/MetaUtils.java

+
+import androidx.fragment.app.FragmentActivity;
+
+public class MetaUtils {


@DanielFrTB - There is no logic that is specific to Meta here. Consider renaming. Maybe there is another already present utility class that you can add this method to.

tomer-br-taboola · 2025-01-09T10:22:28Z

Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/MetaAdUICustomization.java

+        // Create custom style properties for the call to action button
+        TBLUiStyleProperties ctaStyleProperties = new TBLCallToActionButtonStylePropertiesBuilder()
+                // Set the visibility of the call to action, the CTA button will be displayed by default if
+                // you want to hide it you need to pass true to the setVisibility method


@DanielFrTB - Please re-read the comment here. It is misleading.

Kotlin/app/src/main/java/com/taboola/kotlin/examples/screens/utils/MetaUtils.kt

tomer-br-taboola

@DanielFrTB - Please go over all comments.

tomer-br-taboola · 2025-01-12T08:39:32Z

Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/MetaAdUICustomization.java

+                .setTypeface(font)
+                .build();
+
+        // Create custom style properties for the call to action button


@DanielFrTB - Why is this code commented out? As mentioned in my previous comment, show the option to publisher that is NOT the default (meaning, hide the CTA).
Leaving commented out code is not a good practice.

@tomer-br-taboola
Mosh ask to put here a commented code for demonstration

tomer-br-taboola · 2025-01-12T08:39:59Z

...rc/main/java/com/taboola/sdk4example/sdk_classic/MetaClassicUnitFragmentUICustomization.java

+                .build();
+
+        // Create custom style properties for the call to action button
+        TBLUiStyleProperties ctaStyleProperties = new TBLCallToActionButtonStylePropertiesBuilder()


@DanielFrTB - Here you didn't apply any changes.

tomer-br-taboola · 2025-01-12T08:40:21Z

.../src/main/java/com/taboola/kotlin/examples/screens/classic/MetaAdUICustomizationsFragment.kt

+                .setTypeface(typefaceArielBold)
+                .build()
+        // Create custom style properties for the call to action button
+        val callToActionButtonStyleProperties =


@DanielFrTB - Here you didn't apply any changes.

tomer-br-taboola · 2025-01-12T08:40:31Z

...n/java/com/taboola/kotlin/examples/screens/classic/MetaUICustomizationClassicUnitFragment.kt

+                .build()
+
+//        // Create custom style properties for the call to action button
+//        val callToActionButtonStyleProperties =


@DanielFrTB - Why is this code commented out? As mentioned in my previous comment, show the option to publisher that is NOT the default (meaning, hide the CTA).
Leaving commented out code is not a good practice.

@tomer-br-taboola
Mosh ask to put here a commented code for demonstration

tomer-br-taboola

@DanielFrTB - Please go over comments

DanielFrTB added 2 commits January 8, 2025 14:13

MOB-3869-Add a sample screen to example app of API customization

6e1ff6e

MOB-3869-add lines spacing and amount of space

5276c75

DanielFrTB requested review from voltfmanSlava and tomer-br-taboola January 8, 2025 12:36

tomer-br-taboola reviewed Jan 8, 2025

View reviewed changes

Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/MetaAdUICustomization.java Show resolved Hide resolved

tomer-br-taboola reviewed Jan 8, 2025

View reviewed changes

tomer-br-taboola requested changes Jan 8, 2025

View reviewed changes

MOB-3869-PR comments

c48ccb2

tomer-br-taboola reviewed Jan 9, 2025

View reviewed changes

Kotlin/app/src/main/java/com/taboola/kotlin/examples/screens/utils/MetaUtils.kt Outdated Show resolved Hide resolved

tomer-br-taboola requested changes Jan 9, 2025

View reviewed changes

MOB-3869- PR comments

23895cf

DanielFrTB requested a review from tomer-br-taboola January 12, 2025 08:08

tomer-br-taboola reviewed Jan 12, 2025

View reviewed changes

tomer-br-taboola requested changes Jan 12, 2025

View reviewed changes

DanielFrTB requested a review from tomer-br-taboola January 12, 2025 09:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MOB-3869-Add a sample screen to example app of API customization #6

MOB-3869-Add a sample screen to example app of API customization #6

DanielFrTB commented Jan 8, 2025

tomer-br-taboola Jan 8, 2025

DanielFrTB Jan 8, 2025

tomer-br-taboola Jan 8, 2025

DanielFrTB Jan 8, 2025

tomer-br-taboola Jan 8, 2025

DanielFrTB Jan 8, 2025

tomer-br-taboola Jan 9, 2025

tomer-br-taboola Jan 8, 2025

tomer-br-taboola Jan 8, 2025

DanielFrTB Jan 8, 2025

tomer-br-taboola Jan 8, 2025

tomer-br-taboola left a comment

tomer-br-taboola Jan 9, 2025

tomer-br-taboola Jan 9, 2025 •

edited

Loading

tomer-br-taboola Jan 9, 2025

tomer-br-taboola Jan 9, 2025

tomer-br-taboola left a comment

tomer-br-taboola Jan 12, 2025

DanielFrTB Jan 12, 2025

tomer-br-taboola Jan 12, 2025

tomer-br-taboola Jan 12, 2025

tomer-br-taboola Jan 12, 2025

DanielFrTB Jan 12, 2025

tomer-br-taboola left a comment


		import androidx.fragment.app.FragmentActivity;

		public class MetaUtils {

MOB-3869-Add a sample screen to example app of API customization #6

Are you sure you want to change the base?

MOB-3869-Add a sample screen to example app of API customization #6

Conversation

DanielFrTB commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomer-br-taboola left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomer-br-taboola Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomer-br-taboola left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomer-br-taboola left a comment

Choose a reason for hiding this comment

tomer-br-taboola Jan 9, 2025 •

edited

Loading