chore(sdf, dal): Cleanup old pre-REBAC routes

[stack72]

No description provided.

[github-actions]

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

[britmyerss]

are we using this still? or can this one get cleaned up?

Way back when, I was considering keeping the low-fi approval flow for things like 'abandon change set' (as it gives people who are on the change set a chance to stop the abandon if they're actively doing something) but wasn't totally sure...

[stack72]

I do see that an endpoint still is called so I left it in place - it's when the user is an approver or an owner and they force their own approval

[britmyerss]

Sorry bad github comment location - I meant the begin_approval_process pieces

[britmyerss]

Definitely not for this PR - just leaving a note that we need to update both this client and the tests to account for views when we clean up that feature flag

[stack72]

Ok, so I was able to test this by going through the flow of merging a change set in a workspace as the owner. Then going through the request approval, reject, make edits, request approval and approve

[stack72]

API Tests running against this branch

~~ FINAL REPORT GENERATED ~~
Test Report:
[
  {
    "test_name": "6-get_head_changeset",
    "start_time": "2025-01-18T17:12:55.298Z",
    "finish_time": "2025-01-18T17:12:55.352Z",
    "test_duration": "54ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 7,
    "uuid": "5cf2f54e-e297-4e05-8a3f-eec999403e1c"
  },
  {
    "test_name": "0-add_action",
    "start_time": "2025-01-18T17:12:55.295Z",
    "finish_time": "2025-01-18T17:12:56.028Z",
    "test_duration": "733ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 1,
    "uuid": "fbd70edd-2cc0-4c21-864b-c8a7a60669dd"
  },
  {
    "test_name": "2-create_and_delete_component",
    "start_time": "2025-01-18T17:12:55.298Z",
    "finish_time": "2025-01-18T17:12:56.816Z",
    "test_duration": "1518ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 5,
    "uuid": "23ec7375-fab3-48ea-8fc6-6d98a7b8bb38"
  },
  {
    "test_name": "3-create_and_use_variant",
    "start_time": "2025-01-18T17:12:55.297Z",
    "finish_time": "2025-01-18T17:12:57.761Z",
    "test_duration": "2464ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 3,
    "uuid": "2f2846c3-0791-4a2f-8dff-cced6d23d78b"
  },
  {
    "test_name": "4-create_two_components_connect_and_propagate",
    "start_time": "2025-01-18T17:12:55.298Z",
    "finish_time": "2025-01-18T17:13:05.403Z",
    "test_duration": "10105ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 6,
    "uuid": "4d621ff0-6fda-4484-82e8-f311f44e9219"
  },
  {
    "test_name": "7-emulate_authoring",
    "start_time": "2025-01-18T17:12:55.297Z",
    "finish_time": "2025-01-18T17:13:08.013Z",
    "test_duration": "12716ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 2,
    "uuid": "60eef501-a1ae-41e1-80f9-091dae3a17ad"
  },
  {
    "test_name": "5-emulate_paul_stack",
    "start_time": "2025-01-18T17:12:55.298Z",
    "finish_time": "2025-01-18T17:13:16.364Z",
    "test_duration": "21066ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 8,
    "uuid": "1b45e531-b0ac-44f8-8e34-e04f03bf45ba"
  },
  {
    "test_name": "1-create_and_apply_across_change_sets",
    "start_time": "2025-01-18T17:12:55.297Z",
    "finish_time": "2025-01-18T17:13:17.871Z",
    "test_duration": "22574ms",
    "test_result": "success",
    "message": "",
    "test_execution_sequence": 4,
    "uuid": "89ed0246-c643-4cfb-801b-bc19d987cd60"
  }
]