fix(vm-scanning): Fix conditionals for modular #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haresh-suresh
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
LGTM
For future, maybe should consider renaming the cloud_id datasource param to be more explicit for AWS vs GCP
But this should help unblock the issue in us4. Also we will need to verify that this does not cause any regression in AWS while fixing the GCP regions installs.
haresh-suresh
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For modular installs, the current set of conditionals on which agentless WIF backend resource to create, incorrectly chooses AWS for GCP backends. Fixing the conditionals for modular installs.
Testing done :-
Note: this PR needs to be tested properly.