Skip to content

Commit

Permalink
Make external_id a required var in webhook-datasource module (#26)
Browse files Browse the repository at this point in the history
Change summary:
----------------
The external_id variable was made optional so as to not break
onboarding backend. In the backend, we always ensure passing
the external_id to the module, because if not provided, the
validation for the same would fail via WIF.

Making this required now (as it should be) since backend is all merged.
  • Loading branch information
ravinadhruve10 authored Apr 15, 2024
1 parent 6c1ca9f commit 9d48337
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modules/services/webhook-datasource/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ No modules.
| <a name="input_project_id"></a> [project\_id](#input\_project\_id) | (Required) Target Project identifier provided by the customer | `string` | n/a | yes |
| <a name="input_push_endpoint"></a> [push\_endpoint](#input\_push\_endpoint) | (Required) Final endpoint towards which audit logs POST calls will be directed | `string` | n/a | yes |
| <a name="input_role_name"></a> [role\_name](#input\_role\_name) | (Optional) Role name for custom role binding to the service account, with read permissions for data ingestion resources | `string` | `"SysdigIngestionAuthRole"` | no |
| <a name="input_external_id"></a> [external\_id](#input\_external\_id) | (Optional) Random string generated unique to a customer | `string` | `""` | no |
| <a name="input_external_id"></a> [external\_id](#input\_external\_id) | (Required) Random string generated unique to a customer | `string` | n/a | yes |
| <a name="input_suffix"></a> [suffix](#input\_suffix) | (Optional) Suffix to uniquely identify resources during multiple installs. If not provided, random value is autogenerated | `string` | `null` | no |

## Outputs
Expand Down
3 changes: 1 addition & 2 deletions modules/services/webhook-datasource/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ variable "role_name" {

variable "external_id" {
type = string
description = "Random string generated unique to a customer"
default = ""
description = "(Required) Random string generated unique to a customer"
}

variable "suffix" {
Expand Down

0 comments on commit 9d48337

Please sign in to comment.