Skip to content

Commit

Permalink
ICU4C Updating Number Format (unicode-org#154)
Browse files Browse the repository at this point in the history
* Starting on CPP number format

* Start CPP NumberFormat. Improved CPP Collation

* CPP Collation: Use only C++ version

* CPP Collation: Use only C++ version

* Fixing ICU4C number format calls

* Update makefile. Removing files from the commit

* removing changes not needed in this PR

* fix testreport issue

* Updating collation and starting to add lang names and likely subtags

* Resolving "Don't submit"

* Fixing differences

* Minor fix

* Adding ICU4C running collation tests - first try

* Cache ICU4C binaries in GH and locally, only if they don't exist

* Install JSON-C dependency if not installed at beginning of CI or e2e script

* Fix bash if condition syntax

* More options in CPP number format. Improved characterization, too

* Fixing more CPP number_format cases

* Fixing digits settings

* Update currency width

* Set decimal always

* Set numbering system

* Characterize insert/delete space

* Update min significant digits and schema

* Update test strings

---------

Co-authored-by: Elango Cheran <[email protected]>
  • Loading branch information
sven-oly and echeran authored Jan 8, 2024
1 parent d819cfa commit 6998aaf
Show file tree
Hide file tree
Showing 14 changed files with 678 additions and 82 deletions.
4 changes: 0 additions & 4 deletions executors/cpp/likely_subtags.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
/********************************************************************
* Comments and license as needed
************************************
/******
* testing likely subtags for locales
*/
Expand Down
14 changes: 4 additions & 10 deletions executors/cpp/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,11 @@ extern const string test_langnames(json_object *json_in);
extern const string test_likely_subtags(json_object *json_in);
extern const string test_numfmt(json_object *json_in);

// extern const string test_numfmt(json_object *json_in);
std::string supported_tests[6] = {
"collation_short"
std::string supported_tests[4] = {
"collation_short",
"likely_subtags",
"lang_names",
"likely_subtags"
"number_fmt",
"number_fmt"
};


Expand Down Expand Up @@ -111,18 +110,13 @@ int main(int argc, const char** argv)
else if (test_type == "lang_names") {
outputLine = test_langnames(json_input);
}
else if (test_type == "likely_subtags") {
// !!! outputLine = test_likely_subtags(json_input);
}
else {
outputLine = "# BAD TEST " + test_type;
// "{\"error\": \"unknown test type\"," +
// "\"test_type\":" + test_type + "," +
// "\"unsupported_test:\"" + test_type + "}";
}

// TODO: Instead of a string, get JSON output and stringify it.
// cout << "# GOT FROM TEST: " << outputLine << endl;
cout << outputLine << endl;
}

Expand Down
Loading

0 comments on commit 6998aaf

Please sign in to comment.