Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loop version of deposit4626() [sup-9062] #647

Merged
merged 14 commits into from
Oct 28, 2024

Conversation

TamaraRingas
Copy link

Internalize what's inside deposit4626 and create a batchDeposit4626 that just loops over the internal function and update tests.

@TamaraRingas TamaraRingas self-assigned this Oct 25, 2024
Copy link

linear bot commented Oct 25, 2024

Copy link
Contributor

@0xTimepunk 0xTimepunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor thing

src/router-plus/SuperformRouterPlus.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@0xTimepunk 0xTimepunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TamaraRingas TamaraRingas merged commit 6a010e7 into v1.5 Oct 28, 2024
6 checks passed
@TamaraRingas TamaraRingas deleted the tamara-sup-9062-add-loop-version-of-deposit4626 branch October 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants