Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update approvals in routerplus [SUP-8878] #643

Merged
merged 46 commits into from
Oct 30, 2024
Merged

fix: update approvals in routerplus [SUP-8878] #643

merged 46 commits into from
Oct 30, 2024

Conversation

TamaraRingas
Copy link

@TamaraRingas TamaraRingas commented Oct 21, 2024 •
edited by 0xTimepunk
Loading

  • add global slippage parameter
  • add and test setter for global slippage
  • add additional slippage checks to _rebalancePositionsSync() _deposit4626
  • update _deposit() to use amountIn instead of available balance

@TamaraRingas TamaraRingas self-assigned this Oct 21, 2024
@linear Linear
Copy link

linear bot commented Oct 21, 2024

SUP-8878 Fix approvals in RouterPlus

0xTimepunk and others added 18 commits October 21, 2024 20:09
@0xTimepunk
test: fix amount in calculation
b912b3c
@TamaraRingas
Merge pull request #644 from superform-xyz/tamara-sup-8878-joao-fix
c8af790 
test: fix amount in calculation
@TamaraRingas
refactor: rm global slippage setter in constructor
b8036d3
@TamaraRingas
refactor: set global slippage in setUp()
25193dc
@TamaraRingas
reorder test_revert_dispatchPayload_invalidCaller() to revert correctly
c398275
@TamaraRingas
chore: update test_rebalanceSinglePosition_multiDstMultiVaultDepositS…
9a4c463 
…elector()
@TamaraRingas
chore: update test_rebalanceSinglePosition_multiDstMultiVaultDepositS…
9f02765 
…elector()
@0xTimepunk
fix: simplify test structure
9817472
@TamaraRingas
fix: rm tests relating to disputeRefund()
bb0867a
@TamaraRingas
fix: rm overrides
260f2a1
@TamaraRingas
fix: update liqReqs for multidstmultivault rebalance
e246f49
@TamaraRingas
chore: add test_rebalanceSinglePosition_singleXChainMultiVaultDeposit()
c9f1be4
@TamaraRingas
chore: add test_rebalanceSinglePosition_singleXChainSingleVaultDeposi…
7885dfc 
…tSelector()
@TamaraRingas
chore: add _buildRebalanceMultiMultiDstSingleVaultArgs()
55422db
@TamaraRingas
fix: update superformIds in test_rebalanceSinglePosition_multiDstSing…
71b836a 
…leVaultDepositSelector()
@TamaraRingas
fix: update return storage location _buildRebalanceMultiMultiDstSingl…
751d71c 
…eVaultArgs()
@TamaraRingas
fix: update _buildRebalanceMultiMultiDstSingleVaultArgs()
7be0cc8
@TamaraRingas
fix: update _buildRebalanceMultiMultiDstSingleVaultArgs()
e1f91fc
@TamaraRingas
refactor: split _buildRebalanceMultiMultiDstSingleVaultArgs() into he…
79fe34d 
…lpers
@TamaraRingas
add _buildRebalanceMultiMultiDstSingleVaultArgs()
4c79081
@TamaraRingas
fix: update _buildRebalanceMultiMultiDstSingleVaultArgs()
c8a3e8a
@TamaraRingas
fix: update _xChainDeposit() calls in test_rebalanceSinglePosition_mu…
fa32bf5 
…ltiDstSingleVaultDepositSelector()
@TamaraRingas
fix: update params in _buildSingleVaultSFData()
a775456
@TamaraRingas
update REBALANCE_TO chainId in test_rebalanceSinglePosition_multiDstS…
ca0e563 
…ingleVaultDepositSelector()
@TamaraRingas
fix: update REBALANCE_TO chainId in test_rebalanceSinglePosition_mult…
8e2c0b7 
…iDstSingleVaultDepositSelector()
@TamaraRingas
fix: update fork in test_rebalanceSinglePosition_multiDstSingleVaultD…
2d7208a 
…epositSelector()
@TamaraRingas
fix: rm unused helper functions
9e60021
@TamaraRingas
fux: rm _buildRebalanceMultiMultiDstSingleVaultArgs()
53d46c0
@TamaraRingas
fix: update test_rebalanceMultiPositions_multiDstSingleVaultDepositSe…
b613612 
…lector()
@TamaraRingas
import MultiDstSingleVaultStateReq
61a12ab
@0xTimepunk 0xTimepunk marked this pull request as ready for review October 29, 2024 15:53
0xTimepunk
0xTimepunk approved these changes Oct 30, 2024
View reviewed changes
src/router-plus/SuperformRouterPlus.sol Outdated Show resolved Hide resolved
src/router-plus/SuperformRouterPlus.sol Outdated Show resolved Hide resolved
src/router-plus/SuperformRouterPlus.sol Show resolved Hide resolved
@0xTimepunk 0xTimepunk merged commit 15d5530 into v1.5 Oct 30, 2024
6 checks passed
@0xTimepunk 0xTimepunk deleted the tamara-sup-8878-fix-approvals-in-routerplus branch December 9, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTimepunk 0xTimepunk 0xTimepunk approved these changes

Assignees

@TamaraRingas TamaraRingas

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TamaraRingas @0xTimepunk