Skip to content

Commit

Permalink
Merge pull request #71 from Danyylka/main
Browse files Browse the repository at this point in the history
Fixing spelling errors in code/documentation
  • Loading branch information
vikramarun authored Dec 5, 2024
2 parents 14eeff2 + fff5f8e commit d25b195
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ Detailed view, inside of a protocol directory:
├── next-implementation-2
├── ExampleERC4626Vault.sol

Each protocol directory should have its own `test` with coresponding entry in `MakeFile`. Follow established naming patterns. You can create additional directories inside of a protocol directory or host your Vaults together in root directory.
Each protocol directory should have its own `test` with corresponding entry in `MakeFile`. Follow established naming patterns. You can create additional directories inside of a protocol directory or host your Vaults together in root directory.
2 changes: 1 addition & 1 deletion src/kycdao-4626/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Serves as an example to provide gated access to a pool.

The kycDAO platform, which can be accessed at https://kycdao.xyz/, represents a compliance framework that has been natively built for web3 applications. Its primary purpose is to facilitate the use of compliant smart contracts.

In the context of this project, the kycDAO smart contracts [dynamic soulbound NFTs] have been employed to implement a gating mechanism. This mechanism restricts access to the vault to a select group of individuals who are recognized as `trusted anons` within the kycDAO community. `Trusted anons` are the compliant. `Trusted anons` are compliant users of the web3 space.
In the context of this project, the kycDAO smart contracts [dynamic soulbound NFTs] have been employed to implement a gating mechanism. This mechanism restricts access to the vault to a select group of individuals who are recognized as `trusted anons` within the kycDAO community. `Trusted anons` are compliant. `Trusted anons` are compliant users of the web3 space.

To learn more about kycDAO's compliance framework : https://docs.kycdao.xyz/

Expand Down
4 changes: 2 additions & 2 deletions src/uniswap-v2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

`./swap-built-in/UniswapV2ERC4626Swap.sol`

Enables users to deposit into Uniswap V2 Pools using either token0 or token1 and receive an Uniswap LP-token representation wrapped in ERC4626 interface. The Vault calculates the optimal amount for splitting the input token into the two required tokens for the deposit operation. When withdrawing, the Vault simulates the expected value of either token0 or token1 (depending on the Vault being used) within a block. The Vault then performs swapJoin() and swapExit() operations to swap the appropriate amounts of token0 and token1 required for the withdrawal. This system can be easily deployed for token0 and token1 of the UniswapV2Pair, using the UniswapV2ERC4626PoolFactory.sol. Currently `UniswapV2ERC4626PoolFactory.sol` is unfinished and therefore on-chain oracle functionality is disabled. Enabling of Factory contract will be paired with neccessary security updates to the core UniswapV2 adapter.
Enables users to deposit into Uniswap V2 Pools using either token0 or token1 and receive an Uniswap LP-token representation wrapped in ERC4626 interface. The Vault calculates the optimal amount for splitting the input token into the two required tokens for the deposit operation. When withdrawing, the Vault simulates the expected value of either token0 or token1 (depending on the Vault being used) within a block. The Vault then performs swapJoin() and swapExit() operations to swap the appropriate amounts of token0 and token1 required for the withdrawal. This system can be easily deployed for token0 and token1 of the UniswapV2Pair, using the UniswapV2ERC4626PoolFactory.sol. Currently `UniswapV2ERC4626PoolFactory.sol` is unfinished and therefore on-chain oracle functionality is disabled. Enabling of Factory contract will be paired with necessary security updates to the core UniswapV2 adapter.

`./no-swap/UniswapV2.sol`

Expand All @@ -15,4 +15,4 @@ It is important for users to exercise caution when integrating with this contrac
# Future Work

- Price manipulation protection (Both at swapJoin and addLiquidity level)
- Deposit Uniswap LP-token directly (Give ERC4626 interface to existing ERC20 Uniswap LP-Token)
- Deposit Uniswap LP-token directly (Give ERC4626 interface to existing ERC20 Uniswap LP-Token)
2 changes: 1 addition & 1 deletion src/venus/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Venus Protocol ERC4626 Adapters

`VenusERC4626Reinvest.sol` - Standard ERC4626 adapter over any available Venus Markets. Venus is a Compound fork protocol on the "market" level. Allowing to deposit and supply assets to the Venus's vTokens. Build on yield-daddy example, extended with a module for rewards harvesting.
`VenusERC4626Reinvest.sol` - Standard ERC4626 adapter over any available Venus Markets. Venus is a Compound fork protocol on the "market" level. Allows to deposit and supply assets to the Venus's vTokens. Build on yield-daddy example, extended with a module for rewards harvesting.

0 comments on commit d25b195

Please sign in to comment.