chore: remove unchecked and inc to 0.8.23

foundry.toml

@@ -2,7 +2,7 @@
 src = 'src'
 out = 'out'
 libs = ['lib']
-solc_version = "0.8.21" # Override for the solc version (setting this ignores `auto_detect_solc`)
+solc_version = "0.8.23" # Override for the solc version (setting this ignores `auto_detect_solc`)
 evm_version = "paris"   # to prevent usage of PUSH0, which is not supported on all chains
 
 

src/_global/swapUtils.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {SafeTransferLib} from "solmate/utils/SafeTransferLib.sol";
 import {ERC20} from "solmate/tokens/ERC20.sol";

src/aave-v2/AaveV2ERC4626Reinvest.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v2/AaveV2ERC4626ReinvestFactory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v2/AaveV2ERC4626ReinvestIncentive.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v2/AaveV2ERC4626ReinvestIncentiveFactory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v2/aave/IAaveMining.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface IAaveMining {
     function claimRewards(address[] calldata assets, uint256 amount, address to) external returns (uint256);

src/aave-v2/aave/ILendingPool.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 // Aave lending pool interface
 // Documentation: https://docs.aave.com/developers/the-core-protocol/lendingpool/ilendingpool

src/aave-v2/test/AaveV2ERC4626Reinvest.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import "forge-std/Test.sol";
 import {ERC20} from "solmate/tokens/ERC20.sol";

src/aave-v2/utils/ISwapRouter.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 pragma abicoder v2;
 
 import "./IUniswapV3SwapCallback.sol";

src/aave-v2/utils/IUniswapV3SwapCallback.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 /// @title Callback for IUniswapV3PoolActions#swap
 /// @notice Any contract that calls IUniswapV3PoolActions#swap must implement this interface

src/aave-v3/AaveV3ERC4626Reinvest.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v3/AaveV3ERC4626ReinvestFactory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v3/AaveV3ERC4626ReinvestIncentive.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v3/AaveV3ERC4626ReinvestIncentiveFactory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v3/AaveV3ERC4626ReinvestUni.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v3/AaveV3ERC4626ReinvestUniFactory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/aave-v3/external/IPool.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 /**
  * @title IPool

src/aave-v3/external/IRewardsController.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 /**
  * @title IRewardsController

src/aave-v3/test/AaveV3ERC4626Reinvest.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import "forge-std/Test.sol";
 import {ERC20} from "solmate/tokens/ERC20.sol";

src/aave-v3/test/AaveV3ERC4626ReinvestIncentive.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import "forge-std/Test.sol";
 import {ERC20} from "solmate/tokens/ERC20.sol";

src/aave-v3/test/AaveV3ERC4626ReinvestUni.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import "forge-std/Test.sol";
 import {ERC20} from "solmate/tokens/ERC20.sol";

src/alpaca/AlpacaERC4626Reinvest.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/alpaca/interfaces/IBToken.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface IBToken {
     function deposit(uint256) external payable;

src/alpaca/interfaces/IFairLaunch.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface IFairLaunch {
     function alpacaPerBlock() external view returns (uint256);

src/alpaca/interfaces/IRewardsCore.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface IRewardsCore {
     function claimRewards(address, address, bytes memory) external;

src/alpaca/interfaces/IVaultConfig.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface IVaultConfig {
     /// @dev Return the bps rate for reserve pool.

src/alpaca/interfaces/WrappedNative.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface WrappedNative {
     function deposit() external payable;

src/alpaca/test/AlpacaERC4626Reinvest.t.sol

@@ -1,5 +1,5 @@
 /// SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import "forge-std/Test.sol";
 import {ERC20} from "solmate/tokens/ERC20.sol";

src/arrakis/Arrakis_Factory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC20} from "solmate/tokens/ERC20.sol";
 import {ERC4626} from "solmate/mixins/ERC4626.sol";

src/arrakis/Arrakis_Non_Native_LP_Vault.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {ERC4626} from "solmate/mixins/ERC4626.sol";
 import {ERC20} from "solmate/tokens/ERC20.sol";

src/arrakis/interfaces/IArrakisRouter.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 import {IGauge} from "./IGauge.sol";
 

src/arrakis/interfaces/IGauge.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface IGauge {
     function withdraw(uint256 amount) external;

src/arrakis/interfaces/IStakePool.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.21;
+pragma solidity ^0.8.23;
 
 interface IStakePool {
     function staking_token() external view returns (address);

src/arrakis/test/Arrakis_Non_Native_LP_Vault.t.sol

@@ -133,26 +133,24 @@ contract Arrakis_LP_Test is Test {
             (,,, feeGrowthOutsideUpper,,,,) = pool.ticks(gUniPool.upperTick());
         }
 
-        unchecked {
-            // calculate fee growth below
-            uint256 feeGrowthBelow;
-            if (tick >= vault.arrakisVault().lowerTick()) {
-                feeGrowthBelow = feeGrowthOutsideLower;
-            } else {
-                feeGrowthBelow = feeGrowthGlobal - feeGrowthOutsideLower;
-            }
-
-            // calculate fee growth above
-            uint256 feeGrowthAbove;
-            if (tick < vault.arrakisVault().upperTick()) {
-                feeGrowthAbove = feeGrowthOutsideUpper;
-            } else {
-                feeGrowthAbove = feeGrowthGlobal - feeGrowthOutsideUpper;
-            }
-
-            uint256 feeGrowthInside = feeGrowthGlobal - feeGrowthBelow - feeGrowthAbove;
-            fee = (liquidity * (feeGrowthInside - feeGrowthInsideLast)) / 0x100000000000000000000000000000000;
+        // calculate fee growth below
+        uint256 feeGrowthBelow;
+        if (tick >= vault.arrakisVault().lowerTick()) {
+            feeGrowthBelow = feeGrowthOutsideLower;
+        } else {
+            feeGrowthBelow = feeGrowthGlobal - feeGrowthOutsideLower;
         }
+
+        // calculate fee growth above
+        uint256 feeGrowthAbove;
+        if (tick < vault.arrakisVault().upperTick()) {
+            feeGrowthAbove = feeGrowthOutsideUpper;
+        } else {
+            feeGrowthAbove = feeGrowthGlobal - feeGrowthOutsideUpper;
+        }
+
+        uint256 feeGrowthInside = feeGrowthGlobal - feeGrowthBelow - feeGrowthAbove;
+        fee = (liquidity * (feeGrowthInside - feeGrowthInsideLast)) / 0x100000000000000000000000000000000;
     }
 
     function getUnderlyingBalances() external view returns (uint256 amount0Current, uint256 amount1Current) {