Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change at eof #171

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: change at eof #171

wants to merge 5 commits into from

Conversation

psteinroe
Copy link
Collaborator

@psteinroe psteinroe commented Jan 14, 2025

trying to fix a bug where all statements are deleted when deleting at eof. and when modifying a statement.

fixes:

  • using line index of old document during change instead of new
  • gracefully handling changes that are out of bounds of the current content. no idea why these are sent, but they are sometimes. instead of investigating where they come from I just added a check to ensure a TextRange is always valid.
  • change_range in ModifiedStatement was not adapted to the range of the statement, causing a crash and invalid diagnostics ranges when modifying within a statement.

@psteinroe psteinroe marked this pull request as ready for review January 14, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant