Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 45th eMBee's idea - info in label-search-results-mode about amount of all threads and these unread ones #365

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tradzik
Copy link

@tradzik tradzik commented Jan 3, 2015

@eMBee
Copy link
Contributor

eMBee commented Jan 4, 2015

crashes when selecting "unread" from label list
status line takes to much space, should fit in 80 chars or less
do we need to consider configurability?

@tradzik
Copy link
Author

tradzik commented Jan 4, 2015

@eMBee done and fixed

@tradzik tradzik changed the title Implemented 45th eMBee's idea Implemented 45th eMBee's idea - info in label-search-results-mode about amount of all threads and these unread ones Jan 12, 2015
@eMBee
Copy link
Contributor

eMBee commented Jan 13, 2015

you fixed the crash, but the status line still takes to much space. please find a way to make the status display more compact

@eMBee
Copy link
Contributor

eMBee commented Jan 18, 2015

As written there: https://factor.cc/pad/p/sup-ideas using "loaded" instead of "found" is more accurate, because if something isn't found,that doesn't mean it doesn't exist.
@eMBee
Copy link
Contributor

eMBee commented Feb 16, 2015

we have gone over this again, and i believe it is ready to be merged into develop.
since it enhances the UI i can't think of any test that would fit.

@gauteh
Copy link
Member

gauteh commented Feb 18, 2015

Have you been running sup with these changes applied for a while to test them?

@tradzik
Copy link
Author

tradzik commented Feb 18, 2015

@gauteh I am using those changes and I didn't met any error while running them.

@eMBee
Copy link
Contributor

eMBee commented Feb 18, 2015

Excerpts from Tymon Radzik's message of 2015-02-18 19:36:24 +0100:

@gauteh I am using those changes and I didn't met any error while running them.

i am running all ty221 branches merged since this week.

@gauteh
Copy link
Member

gauteh commented Feb 18, 2015

@eMBee: I added you to the committers team, could you merge this PR together to a few meaningful commits (we don't need all sub-fixes and review-fixes, I typically use git rebase -i for this) and push it to the develop branch? Make a test branch on your repository first if you want me to review it first.

@eMBee
Copy link
Contributor

eMBee commented Feb 19, 2015

let me retract that, this needs more work:
i just noticed that the numbers don't seem to get updated when new messages are added or read.

@ty221: could you look into that please?

@tradzik
Copy link
Author

tradzik commented Feb 22, 2015

@eMBee Ok, I didn't meet this problem before, .. Please give me some time to analyse it and eventually fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants