Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set isIncomplete flag on completion item in addition to in the metadata #8

Closed
wants to merge 1 commit into from

Conversation

mskelton
Copy link

@mskelton mskelton commented Mar 7, 2023

isIncomplete is currently being set on the metadata for the completion items from Emmet, but this doesn't work when using Neovim with nvim-cmp which looks for isIncomplete on the actual completion item, rather than in the metadata.

The field is available in the TS definition for ts.CompletionInfo so this seems like an acceptable change.

@mskelton mskelton marked this pull request as ready for review March 7, 2023 02:11
@jasonwilliams
Copy link
Collaborator

Thanks for your contribution, ill look into merging this once the situation with microsoft/TypeScript#51713 (comment) is dealt with

@mskelton
Copy link
Author

mskelton commented Jun 7, 2023

@jasonwilliams Any news on getting this PR merged?

@mskelton mskelton closed this Jul 16, 2023
@jasonwilliams
Copy link
Collaborator

Hey @mskelton is there a reason you closed this?

@mskelton
Copy link
Author

@jasonwilliams It had been sitting open unmerged for a long while, and I don't even use this project anymore, so I was just doing some housekeeping. I can reopen if you want to merge it.

@jasonwilliams
Copy link
Collaborator

Ahh ok thanks, no it’s fine, if we don’t have people to test it it will be hard to merge.

apologies for forgetting about this PR, I don’t use Styled Components anymore and have struggled to get maintainers to replace me.

so let’s keep it closed until someone else wants it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants