Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add xSTRK DEX pools #201

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

feat: Add xSTRK DEX pools #201

wants to merge 9 commits into from

Conversation

ikemHood
Copy link
Contributor

@ikemHood ikemHood commented Dec 30, 2024 •
edited by EjembiEmmanuel
Loading

PR Fixes:

  • 1 added xStrk to Ekubo

Resolves #189

Vercel website link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
  • My PR passes all checks (build, lint, formatting, etc)

EjembiEmmanuel
EjembiEmmanuel requested changes Dec 31, 2024
View reviewed changes
src/store/ekobu.store.ts Outdated
@@ -171,10 +171,14 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'STRK/USDC',
'STRK/ETH',
'USDC/USDT',
'xSTRK/STRK',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be XSTRK/STRK not xSTRK/STRK

src/store/ekobu.store.ts Outdated
@@ -171,10 +171,14 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'STRK/USDC',
'STRK/ETH',
'USDC/USDT',
'xSTRK/STRK',
'xSTRK/USDC',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take out other xSTRK pools as only XSTRK/STRK is supported for now

@EjembiEmmanuel
Copy link
Collaborator

EjembiEmmanuel commented Dec 31, 2024 •
edited
Loading

@ikemHood I pushed some fixes. We figured xSTRK and sSTRK pools were already included in nostradegen.store.ts, so adding them in this PR will result in duplicates. So I removed that part from your PR. Just effect the changes I requested in the comments and it should be good to go. Don't forget to deploy your app on Vercel and provide the link in the description.

@EjembiEmmanuel
Copy link
Collaborator

@ikemHood please deploy your app on Vercel and provide the link in the description

@EjembiEmmanuel
Copy link
Collaborator

@ikemHood please deploy your app on Vercel and provide the link in the description

@ikemHood any progress with this?

@ikemHood
Copy link
Contributor Author

ikemHood commented Jan 5, 2025

https://starkfarm-client-ikemhood.vercel.app/

@EjembiEmmanuel
Copy link
Collaborator

https://starkfarm-client-ikemhood.vercel.app/

@ikemHood I can't see the changes on your deployment. Please confirm that you deployed from the feature branch fix-189.

@ikemHood
Copy link
Contributor Author

ikemHood commented Jan 8, 2025

https://starkfarm-client-ikemhood.vercel.app/

@ikemHood I can't see the changes on your deployment. Please confirm that you deployed from the feature branch fix-189.

oops, wasn't able to deploy the fix-189 branch, vercel selects the defaults branch i can't find a way to change it

@EjembiEmmanuel
Copy link
Collaborator

https://starkfarm-client-ikemhood.vercel.app/

@ikemHood I can't see the changes on your deployment. Please confirm that you deployed from the feature branch fix-189.

oops, wasn't able to deploy the fix-189 branch, vercel selects the defaults branch i can't find a way to change it

@ikemHood please refer to this https://chatgpt.com/share/67811f72-bdcc-8005-a6b1-a57e2ef1a149

@ikemHood
Copy link
Contributor Author

https://starkfarm-client-ikemhood.vercel.app/

@EjembiEmmanuel
Copy link
Collaborator

EjembiEmmanuel commented Jan 12, 2025 •
edited
Loading

@ikemHood please could you look into the failing CI. Confirm you didn't set the HOSTNAME env variable to localhost as that might be the reason it's failing. You can omit setting the HOSTNAME. It's not required to deploy on Vercel

@ikemHood
Copy link
Contributor Author

ikemHood commented Jan 13, 2025 •
edited
Loading

updated https://starkfarm-client-ikemhood.vercel.app/

Screenshot 2025-01-13 at 11 43 36 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EjembiEmmanuel EjembiEmmanuel EjembiEmmanuel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add xSTRK DEX pools
2 participants
@ikemHood @EjembiEmmanuel