-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded SwiftUI example #4445
Open
porter-stripe
wants to merge
19
commits into
master
Choose a base branch
from
porter/swiftui-embedded
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Embedded SwiftUI example #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 New dead code detected in this PR: EmbeddedPaymentElement.swift:485 warning: Parameter 'embeddedPaymentElement' is unused
EmbeddedPaymentElementDelegate.swift:27 warning: Parameter 'embeddedPaymentElement' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EmbeddedPaymentElementView
and a lightweightEmbeddedPaymentViewModel
.makeUIView
is required. Instead of directly attaching the embedded view to SwiftUI, we use a container. This container gives us a fixed point to apply layout constraints and measure the embedded view's size. If we skipped the container and used the embedded view directly, its height would be undefined, causing constraint breakages and leading SwiftUI to treat it as zero.UIViewRepresentable
and the SwiftUI: There is a workaround that would allow us to remove this, but we lose the ability to animate smoothly. Passing this binding to the SwfitUI view allows us to animate the height.Payment
Simulator.Screen.Recording.-.iOS.18.-.2025-01-08.at.10.07.20.mp4
Height animation
Simulator.Screen.Recording.-.iOS.18.-.2025-01-08.at.10.08.43.mp4
Motivation
Testing
Changelog
N/A