Typo #325
Open
Typo #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make isRegistered public * make isRegistered public
* Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2
VolodymyrBg
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
allenchuang
force-pushed
the
dev
branch
2 times, most recently
from
28f0ff0 to
b18d633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
generated.ts: Corrected the import from "viem" to "view".common.ts: Changed the import forHexfrom "viem" to "view".Test Plan
Example:
generated.tsandcommon.tsare correct.Heximport in the affected files.Related Issue
Example: Issue #123
Notes
viewpackage is correctly installed and available in the project dependencies.Changes Made
generated.tsto correct import.common.tsfor consistent imports.packages/core-sdk/src/abi/generated.tspackages/core-sdk/src/constants/common.tsAllow edits by maintainers